Re: [PATCH] media: omap3isp: hist: Move histogram DMA to DMA engine

2015-03-12 Thread Laurent Pinchart
Hi Sakari, Thank you for the review. On Friday 13 March 2015 01:56:32 Sakari Ailus wrote: > On Sun, Mar 08, 2015 at 11:37:55PM +0200, Laurent Pinchart wrote: > ... > > > @@ -198,24 +177,58 @@ static void hist_dma_cb(int lch, u16 ch_status, void > > *data) > > static int hist_buf_dma(struct isps

Re: [PATCH] media: omap3isp: hist: Move histogram DMA to DMA engine

2015-03-12 Thread Sakari Ailus
Hi Laurent, On Sun, Mar 08, 2015 at 11:37:55PM +0200, Laurent Pinchart wrote: ... > @@ -198,24 +177,58 @@ static void hist_dma_cb(int lch, u16 ch_status, void > *data) > static int hist_buf_dma(struct ispstat *hist) > { > dma_addr_t dma_addr = hist->active_buf->dma_addr; > + struct dm

[PATCH] media: omap3isp: hist: Move histogram DMA to DMA engine

2015-03-08 Thread Laurent Pinchart
Replace the custom OMAP DMA API usage by DMA engine. Feature-wise the driver has lost the ability to get notified of DMA transfers failure through the completion handler, as the DMA engine API doesn't expose that status information. Signed-off-by: Laurent Pinchart --- drivers/media/platform/omap