Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

2012-07-21 Thread Chris Ball
Hi, On Thu, Jul 12 2012, S, Venkatraman wrote: On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman khil...@ti.com wrote: If platform_get_resource_by_name() fails, driver probe is aborted an should return an error so the driver is not bound to the device. However, in the current error path of

Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

2012-07-12 Thread S, Venkatraman
On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman khil...@ti.com wrote: If platform_get_resource_by_name() fails, driver probe is aborted an should return an error so the driver is not bound to the device. However, in the current error path of platform_get_resource_by_name(), probe returns zero

[PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

2012-07-10 Thread Kevin Hilman
If platform_get_resource_by_name() fails, driver probe is aborted an should return an error so the driver is not bound to the device. However, in the current error path of platform_get_resource_by_name(), probe returns zero since the return value (ret) is not properly set. With a zero return