Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-04-14 Thread Paul Walmsley
Hi Chris, On Thu, 12 Apr 2012, Chris Ball wrote: > If I understand correctly, the only problem here is the presence of the > warning, so I'm leaning towards just removing it (which we've already > had another request for) or making it pr_debug() instead. Sound okay? Sounds okay to me. We'll pr

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-04-12 Thread Chris Ball
Hi, On Thu, Apr 12 2012, Paul Walmsley wrote: >> With this patch, I continuously get following message on my console. >> (Tested on Origen board, based on EXYNOS4210). >> >> mmc0: Too large timeout requested for CMD25! >> >> So, with this change, should we update sdhci_calc_timeout() also? > > L

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-04-12 Thread Paul Walmsley
Hello Tushar, On Thu, 12 Apr 2012, Tushar Behera wrote: > With this patch, I continuously get following message on my console. > (Tested on Origen board, based on EXYNOS4210). > > mmc0: Too large timeout requested for CMD25! > > So, with this change, should we update sdhci_calc_timeout() also?

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-04-12 Thread Tushar Behera
On 04/06/2012 05:24 AM, Chris Ball wrote: > Hi Paul, > > On Thu, Apr 05 2012, Paul Walmsley wrote: >> I'm really sorry for the long delay! >> >> On Thu, 5 Apr 2012, Chris Ball wrote: >> >>> Thanks. Paul, just waiting for your Signed-off-by. >> >> Signed-off-by: Paul Walmsley > > Thanks, no prob

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-04-05 Thread Chris Ball
Hi Paul, On Thu, Apr 05 2012, Paul Walmsley wrote: > I'm really sorry for the long delay! > > On Thu, 5 Apr 2012, Chris Ball wrote: > >> Thanks. Paul, just waiting for your Signed-off-by. > > Signed-off-by: Paul Walmsley Thanks, no problem! Pushed to mmc-next for 3.4. - Chris. -- Chris Ball

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-04-05 Thread Paul Walmsley
Hi Chris, I'm really sorry for the long delay! On Thu, 5 Apr 2012, Chris Ball wrote: > Thanks. Paul, just waiting for your Signed-off-by. Signed-off-by: Paul Walmsley - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.k

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-04-05 Thread Chris Ball
Hi, On Thu, Apr 05 2012, Tony Lindgren wrote: > * Chris Ball [120315 20:26]: >> Hi Paul, >> >> On Mon, Mar 12 2012, Paul Walmsley wrote: >> > I don't think this is the right fix. Steve Sakoman and I discussed this a >> > few months ago -- we did some debugging and Steve observed the timeouts o

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-04-05 Thread Tony Lindgren
* Chris Ball [120315 20:26]: > Hi Paul, > > On Mon, Mar 12 2012, Paul Walmsley wrote: > > I don't think this is the right fix. Steve Sakoman and I discussed this a > > few months ago -- we did some debugging and Steve observed the timeouts on > > multiple block writes (0x19): > > [...] > > So

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-03-15 Thread Chris Ball
Hi Paul, On Mon, Mar 12 2012, Paul Walmsley wrote: > I don't think this is the right fix. Steve Sakoman and I discussed this a > few months ago -- we did some debugging and Steve observed the timeouts on > multiple block writes (0x19): > [...] > So perhaps something like the following patch ins

RE: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-03-12 Thread Maupin, Chase
> -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Monday, March 12, 2012 5:58 AM > To: Chris Ball > Cc: Maupin, Chase; linux-omap@vger.kernel.org; linux- > m...@vger.kernel.org; sako...@gmail.com > Subject: Re: [PATCH] mmc: omap_hsmmc: set dto

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-03-12 Thread Paul Walmsley
On Mon, 12 Mar 2012, Paul Walmsley wrote: > I don't have an SD bus analyzer, but it looks to me think there are some > SD cards that are not completing the write within the allotted time > window. Heh, sorry. This should, of course, read "looks to me _that_". Sigh... - Paul -- To unsubscrib

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-03-12 Thread Paul Walmsley
+ Steve Sakoman Hi Chris, Chase, Sorry for the late comment on this; I just noticed this thread. On Thu, 8 Mar 2012, Chris Ball wrote: > On Thu, Mar 01 2012, Chase Maupin wrote: > > * With certain SD cards timeouts like the following have been seen > > due to an improper calculation of the dt

RE: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-03-09 Thread Maupin, Chase
> -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Thursday, March 08, 2012 10:39 PM > To: Maupin, Chase > Cc: linux-omap@vger.kernel.org; linux-...@vger.kernel.org > Subject: Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices > > Hi

Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-03-08 Thread Chris Ball
Hi Chase, On Thu, Mar 01 2012, Chase Maupin wrote: > * With certain SD cards timeouts like the following have been seen > due to an improper calculation of the dto value: > mmcblk0: error -110 transferring data, sector 4126233, nr 8, > card status 0xc00 > * By removing the dto calculatio

RE: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-03-06 Thread Maupin, Chase
Chase > Subject: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices > > * With certain SD cards timeouts like the following have been seen > due to an improper calculation of the dto value: > mmcblk0: error -110 transferring data, sector 4126233, nr 8, > card sta

[PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

2012-03-01 Thread Chase Maupin
* With certain SD cards timeouts like the following have been seen due to an improper calculation of the dto value: mmcblk0: error -110 transferring data, sector 4126233, nr 8, card status 0xc00 * By removing the dto calculation and setting the timeout value to the maximum specified by