RE: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-04 Thread Bedia, Vaibhav
Hi Kevin, On Fri, May 04, 2012 at 03:02:16, Hilman, Kevin wrote: Ben Hutchings bhutchi...@solarflare.com writes: On Thu, 2012-05-03 at 19:25 +, Bedia, Vaibhav wrote: On Fri, May 04, 2012 at 00:16:32, Mark A. Greer wrote: [...] So, if I understood this correctly, it's

Re: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-04 Thread Kevin Hilman
+Sekhar Bedia, Vaibhav vaibhav.be...@ti.com writes: Hi Kevin, On Fri, May 04, 2012 at 03:02:16, Hilman, Kevin wrote: Ben Hutchings bhutchi...@solarflare.com writes: On Thu, 2012-05-03 at 19:25 +, Bedia, Vaibhav wrote: On Fri, May 04, 2012 at 00:16:32, Mark A. Greer wrote: [...]

Re: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-04 Thread Mark A. Greer
On Fri, May 04, 2012 at 01:55:58PM +, Bedia, Vaibhav wrote: Hi Vaibhav. Hi Kevin, On Fri, May 04, 2012 at 03:02:16, Hilman, Kevin wrote: Ben Hutchings bhutchi...@solarflare.com writes: On Thu, 2012-05-03 at 19:25 +, Bedia, Vaibhav wrote: On Fri, May 04, 2012 at 00:16:32,

Re: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-04 Thread Kevin Hilman
Hi Mark, Mark A. Greer mgr...@animalcreek.com writes: [...] To work around this issue, add platform data callbacks which are called at the beginning of the open routine and at the end of the stop routine of the davinci_emac driver. The callbacks allow the platform code to issue

Re: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-04 Thread Mark A. Greer
On Fri, May 04, 2012 at 07:31:30AM -0700, Kevin Hilman wrote: Bedia, Vaibhav vaibhav.be...@ti.com writes: Hi Kevin. If it does, perhaps there should some other mechanism for letting users control the system behavior. Come to think of it, the right solution here is probably to use runtime

Re: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-04 Thread Mark A. Greer
On Fri, May 04, 2012 at 09:44:45AM -0700, Kevin Hilman wrote: Hi Mark, Hi Kevin. Mark A. Greer mgr...@animalcreek.com writes: [...] To work around this issue, add platform data callbacks which are called at the beginning of the open routine and at the end of the stop routine of the

Re: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-04 Thread Kevin Hilman
Mark A. Greer mgr...@animalcreek.com writes: On Fri, May 04, 2012 at 07:31:30AM -0700, Kevin Hilman wrote: [...] Come to think of it, the right solution here is probably to use runtime PM. We could then to add some custom hooks for davinci_emac in the device code to use

Re: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-04 Thread Mark A. Greer
On Fri, May 04, 2012 at 02:02:43PM -0700, Kevin Hilman wrote: Mark A. Greer mgr...@animalcreek.com writes: On Fri, May 04, 2012 at 07:31:30AM -0700, Kevin Hilman wrote: [...] Come to think of it, the right solution here is probably to use runtime PM. We could then to add some custom

RE: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-03 Thread Bedia, Vaibhav
On Thu, May 03, 2012 at 05:17:18, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com The davinci EMAC driver has been incorporated into the am35x family of SoC's which is OMAP-based. The incorporation is incomplete in that the EMAC cannot unblock the [ARM] core if its blocked

Re: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-03 Thread Kevin Hilman
Bedia, Vaibhav vaibhav.be...@ti.com writes: On Thu, May 03, 2012 at 05:17:18, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com The davinci EMAC driver has been incorporated into the am35x family of SoC's which is OMAP-based. The incorporation is incomplete in that the EMAC

Re: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-03 Thread Mark A. Greer
On Thu, May 03, 2012 at 10:44:44AM +, Bedia, Vaibhav wrote: On Thu, May 03, 2012 at 05:17:18, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com The davinci EMAC driver has been incorporated into the am35x family of SoC's which is OMAP-based. The incorporation is

RE: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-03 Thread Bedia, Vaibhav
On Thu, May 03, 2012 at 21:39:18, Mark A. Greer wrote: On Thu, May 03, 2012 at 10:44:44AM +, Bedia, Vaibhav wrote: On Thu, May 03, 2012 at 05:17:18, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com The davinci EMAC driver has been incorporated into the am35x

Re: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-03 Thread Mark A. Greer
On Thu, May 03, 2012 at 06:21:27PM +, Bedia, Vaibhav wrote: On Thu, May 03, 2012 at 21:39:18, Mark A. Greer wrote: On Thu, May 03, 2012 at 10:44:44AM +, Bedia, Vaibhav wrote: On Thu, May 03, 2012 at 05:17:18, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com

RE: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-03 Thread Bedia, Vaibhav
On Fri, May 04, 2012 at 00:16:32, Mark A. Greer wrote: [...] So, if I understood this correctly, it's effectively like blocking a low power state transition (here wfi execution) when EMAC is active? Assuming it is my patch, correct. Recently I was thinking about how to get certain

RE: [PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-03 Thread Ben Hutchings
On Thu, 2012-05-03 at 19:25 +, Bedia, Vaibhav wrote: On Fri, May 04, 2012 at 00:16:32, Mark A. Greer wrote: [...] So, if I understood this correctly, it's effectively like blocking a low power state transition (here wfi execution) when EMAC is active? Assuming it is my

[PATCH] net: davinci_emac: Add pre_open, post_stop platform callbacks

2012-05-02 Thread Mark A. Greer
From: Mark A. Greer mgr...@animalcreek.com The davinci EMAC driver has been incorporated into the am35x family of SoC's which is OMAP-based. The incorporation is incomplete in that the EMAC cannot unblock the [ARM] core if its blocked on a 'wfi' instruction. This is an issue with the cpu_idle