Re: [PATCH] regulator: palmas: Fix SMPS enable/disable/is_enabled

2014-06-23 Thread Stephen Warren
On 06/23/2014 02:20 PM, Stephen Warren wrote: > On 06/23/2014 02:11 PM, Nishanth Menon wrote: >> On Mon, Jun 23, 2014 at 2:50 PM, Stephen Warren >> wrote: >>> On 06/20/2014 11:26 AM, Nishanth Menon wrote: We use regmap regulator ops to enable/disable and check if regulator is enabled fo

Re: [PATCH] regulator: palmas: Fix SMPS enable/disable/is_enabled

2014-06-23 Thread Nishanth Menon
On Mon, Jun 23, 2014 at 3:20 PM, Stephen Warren wrote: > On 06/23/2014 02:11 PM, Nishanth Menon wrote: >> On Mon, Jun 23, 2014 at 2:50 PM, Stephen Warren >> wrote: >>> On 06/20/2014 11:26 AM, Nishanth Menon wrote: We use regmap regulator ops to enable/disable and check if regulator is

Re: [PATCH] regulator: palmas: Fix SMPS enable/disable/is_enabled

2014-06-23 Thread Stephen Warren
On 06/23/2014 02:11 PM, Nishanth Menon wrote: > On Mon, Jun 23, 2014 at 2:50 PM, Stephen Warren wrote: >> On 06/20/2014 11:26 AM, Nishanth Menon wrote: >>> We use regmap regulator ops to enable/disable and check if regulator >>> is enabled for various SMPS. However, these depend on valid >>> enabl

Re: [PATCH] regulator: palmas: Fix SMPS enable/disable/is_enabled

2014-06-23 Thread Nishanth Menon
On Mon, Jun 23, 2014 at 2:50 PM, Stephen Warren wrote: > On 06/20/2014 11:26 AM, Nishanth Menon wrote: >> We use regmap regulator ops to enable/disable and check if regulator >> is enabled for various SMPS. However, these depend on valid >> enable_reg, enable_mask and enable_value in regulator des

Re: [PATCH] regulator: palmas: Fix SMPS enable/disable/is_enabled

2014-06-23 Thread Stephen Warren
On 06/20/2014 11:26 AM, Nishanth Menon wrote: > We use regmap regulator ops to enable/disable and check if regulator > is enabled for various SMPS. However, these depend on valid > enable_reg, enable_mask and enable_value in regulator descriptor. > > Currently we do not populate these for SMPS oth

Re: [PATCH] regulator: palmas: Fix SMPS enable/disable/is_enabled

2014-06-21 Thread Mark Brown
On Fri, Jun 20, 2014 at 12:26:23PM -0500, Nishanth Menon wrote: > We use regmap regulator ops to enable/disable and check if regulator > is enabled for various SMPS. However, these depend on valid > enable_reg, enable_mask and enable_value in regulator descriptor. Applied, thanks. signature.asc

Re: [PATCH] regulator: palmas: Fix SMPS enable/disable/is_enabled

2014-06-20 Thread Alexandre Courbot
On Sat, Jun 21, 2014 at 2:26 AM, Nishanth Menon wrote: > We use regmap regulator ops to enable/disable and check if regulator > is enabled for various SMPS. However, these depend on valid > enable_reg, enable_mask and enable_value in regulator descriptor. > > Currently we do not populate these for

[PATCH] regulator: palmas: Fix SMPS enable/disable/is_enabled

2014-06-20 Thread Nishanth Menon
We use regmap regulator ops to enable/disable and check if regulator is enabled for various SMPS. However, these depend on valid enable_reg, enable_mask and enable_value in regulator descriptor. Currently we do not populate these for SMPS other than SMPS10, this results in spurious results as regm