Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-14 Thread Felipe Contreras
g...@kroah.com wrote: On Sun, Mar 13, 2011 at 01:42:35AM +0200, Felipe Contreras wrote: On Sat, Mar 12, 2011 at 7:36 PM, Greg KH g...@kroah.com wrote: How about I send it to Linus for .39 and then add it to the .38-stable tree when it comes out? That was the plan for .38/.37-stable.

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-14 Thread Greg KH
On Mon, Mar 14, 2011 at 05:33:09PM +0200, Felipe Contreras wrote: g...@kroah.com wrote: On Sun, Mar 13, 2011 at 01:42:35AM +0200, Felipe Contreras wrote: On Sat, Mar 12, 2011 at 7:36 PM, Greg KH g...@kroah.com wrote: How about I send it to Linus for .39 and then add it to the .38-stable

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-12 Thread Greg KH
On Fri, Mar 11, 2011 at 06:29:06PM -0600, Omar Ramirez Luna wrote: Hi Greg, Please consider to apply this patch in the staging tree, as the description says it fixes a crash in tidspbridge driver, this bug was already present but it seems to have surfaced by recent tests made by Felipe and

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-12 Thread Felipe Contreras
On Sat, Mar 12, 2011 at 7:36 PM, Greg KH g...@kroah.com wrote: On Fri, Mar 11, 2011 at 06:29:06PM -0600, Omar Ramirez Luna wrote: Please consider to apply this patch in the staging tree, as the description says it fixes a crash in tidspbridge driver, this bug was already present but it seems

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-12 Thread Greg KH
On Sun, Mar 13, 2011 at 01:42:35AM +0200, Felipe Contreras wrote: On Sat, Mar 12, 2011 at 7:36 PM, Greg KH g...@kroah.com wrote: On Fri, Mar 11, 2011 at 06:29:06PM -0600, Omar Ramirez Luna wrote: Please consider to apply this patch in the staging tree, as the description says it fixes a

[RESEND PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-11 Thread Felipe Contreras
We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the scatter-gather list with garbage. So, use the existing proc_lock for that. I observed race conditions which caused kernel panics while running stress tests, also, Tuomas Kulve found it

Re: [RESEND PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-11 Thread Felipe Contreras
On Fri, Mar 11, 2011 at 7:30 PM, Felipe Contreras felipe.contre...@nokia.com wrote: We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the scatter-gather list with garbage. So, use the existing proc_lock for that. I observed race

Re: [RESEND PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-11 Thread Ramirez Luna, Omar
Hi Felipe, On Fri, Mar 11, 2011 at 11:38 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Mar 11, 2011 at 7:30 PM, Felipe Contreras felipe.contre...@nokia.com wrote: We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the

Re: [RESEND PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-11 Thread Felipe Contreras
On Fri, Mar 11, 2011 at 8:05 PM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Fri, Mar 11, 2011 at 11:38 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Omar, 2.6.38 is imminent, if this patch has any chance of getting in, I think you would need to push it soon. I'll push it to my

Re: [RESEND PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-11 Thread Ramirez Luna, Omar
Hi, On Fri, Mar 11, 2011 at 12:31 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Well, not crashing is better than crashing, regardless of the status of the driver. And there's no reason not to include the fix. No reason indeed. But if you send it to Greg, then it's Greg's call. Ok

[PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-11 Thread Omar Ramirez Luna
Hi Greg, Please consider to apply this patch in the staging tree, as the description says it fixes a crash in tidspbridge driver, this bug was already present but it seems to have surfaced by recent tests made by Felipe and Tuomas. It is an urgent fix for 2.6.38. More on this discussion:

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-07 Thread Felipe Contreras
On Mon, Dec 20, 2010 at 7:12 PM, Felipe Contreras felipe.contre...@nokia.com wrote: We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the scatter-gather list with garbage. So, use the existing proc_lock for that. I observed race

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-07 Thread Ohad Ben-Cohen
On Mon, Mar 7, 2011 at 8:02 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Dec 20, 2010 at 7:12 PM, Felipe Contreras felipe.contre...@nokia.com wrote: We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the scatter-gather

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-07 Thread Greg KH
On Mon, Mar 07, 2011 at 08:02:44PM +0200, Felipe Contreras wrote: On Mon, Dec 20, 2010 at 7:12 PM, Felipe Contreras felipe.contre...@nokia.com wrote: We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the scatter-gather list with

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-07 Thread Ramirez Luna, Omar
Hi Felipe, On Mon, Mar 7, 2011 at 12:02 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Dec 20, 2010 at 7:12 PM, Felipe Contreras felipe.contre...@nokia.com wrote: We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2011-03-07 Thread Felipe Contreras
On Mon, Mar 7, 2011 at 9:29 PM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Mon, Mar 7, 2011 at 12:02 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Dec 20, 2010 at 7:12 PM, Felipe Contreras felipe.contre...@nokia.com wrote: We need to protect not only the dmm_map list,

[PATCH] staging: tidspbridge: protect dmm_map properly

2010-12-20 Thread Felipe Contreras
We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the scatter-gather list with garbage. So, use the existing proc_lock for that. I observed race conditions which caused kernel panics while running stress tests. This patch fixes those.

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2010-12-20 Thread Kanigeri, Hari
Felipe, On Mon, Dec 20, 2010 at 11:12 AM, Felipe Contreras felipe.contre...@nokia.com wrote: We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the scatter-gather list with garbage. So, use the existing proc_lock for that. I observed

Re: [PATCH] staging: tidspbridge: protect dmm_map properly

2010-12-20 Thread Felipe Contreras
Hi, On Mon, Dec 20, 2010 at 8:30 PM, Kanigeri, Hari h-kanige...@ti.com wrote: On Mon, Dec 20, 2010 at 11:12 AM, Felipe Contreras felipe.contre...@nokia.com wrote: We need to protect not only the dmm_map list, but the individual map_obj's, otherwise, we might be building the scatter-gather