Re: [PATCH 01/14] ARM: bitops: ensure set/clear/change bitops take a word-aligned pointer

2011-01-25 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [110117 11:20]: Add additional instructions to our assembly bitops functions to ensure that they only operate on word-aligned pointers. This will be necessary when we switch these operations to use the word-based exclusive operations. If it's

Re: [PATCH 01/14] ARM: bitops: ensure set/clear/change bitops take a word-aligned pointer

2011-01-18 Thread Russell King - ARM Linux
On Tue, Jan 18, 2011 at 01:00:21AM -0500, Nicolas Pitre wrote: I also wonder what happens with a misaligned ldrex/strex... Does the alignment trap get invoked? If so, the assertion could be put there instead if that's not done already, removing this overhead from bitops calls. In the

Re: [PATCH 01/14] ARM: bitops: ensure set/clear/change bitops take a word-aligned pointer

2011-01-18 Thread Catalin Marinas
On 18 January 2011 06:00, Nicolas Pitre n...@fluxnic.net wrote: On Mon, 17 Jan 2011, Russell King - ARM Linux wrote: Add additional instructions to our assembly bitops functions to ensure that they only operate on word-aligned pointers.  This will be necessary when we switch these operations

Re: [PATCH 01/14] ARM: bitops: ensure set/clear/change bitops take a word-aligned pointer

2011-01-18 Thread Nicolas Pitre
On Tue, 18 Jan 2011, Russell King - ARM Linux wrote: On Tue, Jan 18, 2011 at 01:00:21AM -0500, Nicolas Pitre wrote: I also wonder what happens with a misaligned ldrex/strex... Does the alignment trap get invoked? If so, the assertion could be put there instead if that's not done

[PATCH 01/14] ARM: bitops: ensure set/clear/change bitops take a word-aligned pointer

2011-01-17 Thread Russell King - ARM Linux
Add additional instructions to our assembly bitops functions to ensure that they only operate on word-aligned pointers. This will be necessary when we switch these operations to use the word-based exclusive operations. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

Re: [PATCH 01/14] ARM: bitops: ensure set/clear/change bitops take a word-aligned pointer

2011-01-17 Thread Nicolas Pitre
On Mon, 17 Jan 2011, Russell King - ARM Linux wrote: Add additional instructions to our assembly bitops functions to ensure that they only operate on word-aligned pointers. This will be necessary when we switch these operations to use the word-based exclusive operations. Signed-off-by: