Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-30 Thread Cousson, Benoit
Second thought... I was too fast to say OK :-) On 9/27/2011 7:40 AM, Nayak, Rajendra wrote: On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: [...] + if (match) { + of_property_read_u32(node, bank-width,bank-width); Bank width should be u32. I guess you

Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-28 Thread Cousson, Benoit
Hi Rajendra, On 9/27/2011 7:40 AM, Nayak, Rajendra wrote: On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: Adapt the GPIO driver to retrieve information from a DT file. Note that since the driver is currently under cleanup, some hacks will have to be removed after. Add

Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-28 Thread Cousson, Benoit
I missed one comment... On 9/27/2011 7:40 AM, Nayak, Rajendra wrote: On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: [...] +Required properties: +- compatible: + - ti,omap2-gpio for OMAP2 and OMAP3 controllers Would it be more readable to have ti,omap2-gpio for OMAP2

Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-28 Thread Scott Wood
On 09/28/2011 03:15 AM, Cousson, Benoit wrote: On 9/27/2011 7:40 AM, Nayak, Rajendra wrote: On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: +Required properties: +- compatible: + - ti,omap2-gpio for OMAP2 and OMAP3 controllers Would it be more readable to have ti,omap2-gpio

Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-28 Thread Cousson, Benoit
On 9/28/2011 8:23 PM, Scott Wood wrote: On 09/28/2011 03:15 AM, Cousson, Benoit wrote: On 9/27/2011 7:40 AM, Nayak, Rajendra wrote: On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: +Required properties: +- compatible: + - ti,omap2-gpio for OMAP2 and OMAP3 controllers Would it be

Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-28 Thread Scott Wood
On 09/28/2011 03:57 PM, Cousson, Benoit wrote: On 9/28/2011 8:23 PM, Scott Wood wrote: What does the id mean, in relation to the actual hardware? It's true that the description is not super meaningful... This is the HW instance number. We have 6 gpios, named gpio1 to gpio6, but the pin

[PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-26 Thread Benoit Cousson
Adapt the GPIO driver to retrieve information from a DT file. Note that since the driver is currently under cleanup, some hacks will have to be removed after. Add documentation for GPIO properties specific to OMAP. Remove an un-needed whitespace. Signed-off-by: Benoit Cousson b-cous...@ti.com

Re: [PATCH 02/13] gpio/omap: Adapt GPIO driver to DT

2011-09-26 Thread Rajendra Nayak
On Monday 26 September 2011 10:20 PM, Benoit Cousson wrote: Adapt the GPIO driver to retrieve information from a DT file. Note that since the driver is currently under cleanup, some hacks will have to be removed after. Add documentation for GPIO properties specific to OMAP. Remove an un-needed