Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-09-01 Thread Sebastian Andrzej Siewior
On 08/18/2014 03:46 PM, Heikki Krogerus wrote: On Fri, Aug 15, 2014 at 07:42:33PM +0200, Sebastian Andrzej Siewior wrote: diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index cc90c19..ab003b6 100644 --- a/drivers/tty/serial/8250/8250_core.c +++

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-29 Thread Sebastian Andrzej Siewior
On 08/16/2014 12:44 AM, Tony Lindgren wrote: Oh and echo mem /sys/power/state and then hitting a key on the serial console won't wake the system. Does that need to be manually configured for device_may_wakeup()? This is what it looks like: /# echo enabled

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-29 Thread Tony Lindgren
* Sebastian Andrzej Siewior bige...@linutronix.de [140829 08:50]: On 08/16/2014 12:44 AM, Tony Lindgren wrote: Oh and echo mem /sys/power/state and then hitting a key on the serial console won't wake the system. Does that need to be manually configured for device_may_wakeup()? This is

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-21 Thread Sebastian Andrzej Siewior
On 08/15/2014 11:07 PM, Tony Lindgren wrote: Nice, now it mostly works for me with off-idle too :) That is as long as I have the DMA channels commented out in the .dts file. And I'm still seeing an occasional hang with pstore console just showing: [ 289.076538] In-band Error seen by MPU

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-21 Thread Tony Lindgren
* Sebastian Andrzej Siewior bige...@linutronix.de [140821 04:04]: On 08/15/2014 11:07 PM, Tony Lindgren wrote: Nice, now it mostly works for me with off-idle too :) That is as long as I have the DMA channels commented out in the .dts file. And I'm still seeing an occasional hang with

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-18 Thread Heikki Krogerus
Hi, On Fri, Aug 15, 2014 at 07:42:33PM +0200, Sebastian Andrzej Siewior wrote: diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index cc90c19..ab003b6 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -264,6

[PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-15 Thread Sebastian Andrzej Siewior
This patch provides a 8250-core based UART driver for the internal OMAP UART. The long term goal is to provide the same functionality as the current OMAP uart driver and DMA support. I tried to merge omap-serial code together with the 8250-core code. There should should be hardly a noticable

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-15 Thread Lennart Sorensen
On Fri, Aug 15, 2014 at 07:42:33PM +0200, Sebastian Andrzej Siewior wrote: This patch provides a 8250-core based UART driver for the internal OMAP UART. The long term goal is to provide the same functionality as the current OMAP uart driver and DMA support. I tried to merge omap-serial code

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-15 Thread Sebastian Andrzej Siewior
On 08/15/2014 08:37 PM, Lennart Sorensen wrote: On Fri, Aug 15, 2014 at 07:42:33PM +0200, Sebastian Andrzej Siewior wrote: This patch provides a 8250-core based UART driver for the internal OMAP UART. The long term goal is to provide the same functionality as the current OMAP uart driver and

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-15 Thread Lennart Sorensen
On Fri, Aug 15, 2014 at 09:27:59PM +0200, Sebastian Andrzej Siewior wrote: If you want to change this to reduce the gap, then you have first change 8250 core code. Currently it waits until the shift register is empty. Oh the 8250 normally works this way? I didn't know that. On the other

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-15 Thread Sebastian Andrzej Siewior
On 08/15/2014 09:33 PM, Lennart Sorensen wrote: On the other hand if you use DMA then it can handle transfers 64bytes in one go and you can start transfers while the FIFO is not completely empty. You can dma more than the fifo size? Yes. The UART asserts the DMA line as long as there is

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-15 Thread Tony Lindgren
* Sebastian Andrzej Siewior bige...@linutronix.de [140815 10:46]: This patch provides a 8250-core based UART driver for the internal OMAP UART. The long term goal is to provide the same functionality as the current OMAP uart driver and DMA support. I tried to merge omap-serial code together

Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver

2014-08-15 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [140815 14:10]: * Sebastian Andrzej Siewior bige...@linutronix.de [140815 10:46]: This patch provides a 8250-core based UART driver for the internal OMAP UART. The long term goal is to provide the same functionality as the current OMAP uart driver and DMA