Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-04-04 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [...] Can the LCD_BL_GPIO be handled by the omap panel driver? Otherwise the backlight will supposedly be always on. Is it just a simple switch for the BL power, which does not affect the SPI in any way? Yes, it can for now. Also, I think we

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-04-03 Thread Tomi Valkeinen
On 2013-02-14 15:51, Igor Grinberg wrote: On 02/14/13 14:52, Tomi Valkeinen wrote: On 2013-02-14 14:37, Igor Grinberg wrote: On 02/14/13 12:59, Tomi Valkeinen wrote: On 2013-02-14 11:43, Igor Grinberg wrote: True, it's generic, but does it work reliably? The panel hardware is now partly

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-14 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/13 09:09, Tomi Valkeinen wrote: On 2013-02-14 08:56, Igor Grinberg wrote: On 02/13/13 17:59, Tomi Valkeinen wrote: Okay, so I just realized there's an spi backlight driver used here, and that backlight driver is actually handling the

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-14 Thread Tomi Valkeinen
On 2013-02-14 10:37, Igor Grinberg wrote: On 02/14/13 09:09, Tomi Valkeinen wrote: On 2013-02-14 08:56, Igor Grinberg wrote: On 02/13/13 17:59, Tomi Valkeinen wrote: Okay, so I just realized there's an spi backlight driver used here, and that backlight driver is actually handling the SPI

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-14 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/13 11:09, Tomi Valkeinen wrote: On 2013-02-14 10:37, Igor Grinberg wrote: On 02/14/13 09:09, Tomi Valkeinen wrote: On 2013-02-14 08:56, Igor Grinberg wrote: On 02/13/13 17:59, Tomi Valkeinen wrote: Okay, so I just realized there's an

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-14 Thread Tomi Valkeinen
On 2013-02-14 11:43, Igor Grinberg wrote: True, it's generic, but does it work reliably? The panel hardware is now partly handled in the backlight driver, and partly in the omap's panel driver (and wherever on other platforms). It works reliably on other platforms, but not on OMAP - because

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-14 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/13 12:59, Tomi Valkeinen wrote: On 2013-02-14 11:43, Igor Grinberg wrote: True, it's generic, but does it work reliably? The panel hardware is now partly handled in the backlight driver, and partly in the omap's panel driver (and

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-14 Thread Tomi Valkeinen
On 2013-02-14 14:37, Igor Grinberg wrote: On 02/14/13 12:59, Tomi Valkeinen wrote: On 2013-02-14 11:43, Igor Grinberg wrote: True, it's generic, but does it work reliably? The panel hardware is now partly handled in the backlight driver, and partly in the omap's panel driver (and wherever

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-14 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/14/13 14:52, Tomi Valkeinen wrote: On 2013-02-14 14:37, Igor Grinberg wrote: On 02/14/13 12:59, Tomi Valkeinen wrote: On 2013-02-14 11:43, Igor Grinberg wrote: True, it's generic, but does it work reliably? The panel hardware is now partly

[PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-13 Thread Archit Taneja
The cm-t35 board file currently requests gpios required to configure the tdo35s panel, and provides platform_enable/disable callbacks to configure them. These tasks have been moved to the generic dpi panel driver itself and shouldn't be done in the board files. Remove the gpio requests and the

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-13 Thread Igor Grinberg
Hi Archit, On 02/13/13 16:21, Archit Taneja wrote: The cm-t35 board file currently requests gpios required to configure the tdo35s panel, and provides platform_enable/disable callbacks to configure them. These tasks have been moved to the generic dpi panel driver itself and shouldn't be

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-13 Thread Tomi Valkeinen
On 2013-02-13 17:16, Igor Grinberg wrote: Hi Archit, On 02/13/13 16:21, Archit Taneja wrote: The cm-t35 board file currently requests gpios required to configure the tdo35s panel, and provides platform_enable/disable callbacks to configure them. These tasks have been moved to the generic

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-13 Thread Tomi Valkeinen
On 2013-02-13 17:28, Tomi Valkeinen wrote: On 2013-02-13 17:16, Igor Grinberg wrote: Hi Archit, On 02/13/13 16:21, Archit Taneja wrote: The cm-t35 board file currently requests gpios required to configure the tdo35s panel, and provides platform_enable/disable callbacks to configure them.

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-13 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/13/13 17:59, Tomi Valkeinen wrote: On 2013-02-13 17:28, Tomi Valkeinen wrote: On 2013-02-13 17:16, Igor Grinberg wrote: Hi Archit, On 02/13/13 16:21, Archit Taneja wrote: The cm-t35 board file currently requests gpios required to configure

Re: [PATCH 05/33] arm: omap: board-cm-t35: use generic dpi panel's gpio handling

2013-02-13 Thread Tomi Valkeinen
On 2013-02-14 08:56, Igor Grinberg wrote: On 02/13/13 17:59, Tomi Valkeinen wrote: Okay, so I just realized there's an spi backlight driver used here, and that backlight driver is actually handling the SPI transactions with the panel, instead of the panel driver. So this looks quite messed