RE: [PATCH 06/13] OMAP: hwmod: add non-locking versions of enable and idle functions

2010-06-24 Thread Basak, Partha
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Paul Walmsley Sent: Thursday, June 24, 2010 10:39 AM To: Kevin Hilman Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH 06/13] OMAP: hwmod: add non-locking versions

Re: [PATCH 06/13] OMAP: hwmod: add non-locking versions of enable and idle functions

2010-06-24 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Kevin On Wed, 23 Jun 2010, Kevin Hilman wrote: Some hwmods may need to be idled/enabled in atomic context, so non-locking versions of these functions are required. Most users should not need these and usage of theses should be controlled to

Re: [PATCH 06/13] OMAP: hwmod: add non-locking versions of enable and idle functions

2010-06-24 Thread Kevin Hilman
Basak, Partha p-bas...@ti.com writes: [...] /** * omap_hwmod_idle - idle an omap_hwmod * @oh: struct omap_hwmod * @@ -1319,9 +1345,7 @@ int omap_hwmod_idle(struct omap_hwmod *oh) if (!oh) return -EINVAL; - mutex_lock(omap_hwmod_mutex); - _idle(oh); -

[PATCH 06/13] OMAP: hwmod: add non-locking versions of enable and idle functions

2010-06-23 Thread Kevin Hilman
Some hwmods may need to be idled/enabled in atomic context, so non-locking versions of these functions are required. Most users should not need these and usage of theses should be controlled to understand why access is being done in atomic context. For this reason, the non-locking functions are

Re: [PATCH 06/13] OMAP: hwmod: add non-locking versions of enable and idle functions

2010-06-23 Thread Paul Walmsley
Hi Kevin On Wed, 23 Jun 2010, Kevin Hilman wrote: Some hwmods may need to be idled/enabled in atomic context, so non-locking versions of these functions are required. Most users should not need these and usage of theses should be controlled to understand why access is being done in atomic