Re: [PATCH 06/16] tty: serial: Add 8250-core based omap driver

2014-09-29 Thread Frans Klaver
On Wed, Sep 10, 2014 at 09:30:01PM +0200, Sebastian Andrzej Siewior wrote: + /* + * We enable TRIG_GRANU for RX and TX and additionaly we set + * SCR_TX_EMPTY bit. The result is the following: + * - RX_TRIGGER amount of bytes in the FIFO will cause an interrupt. + * -

Re: [PATCH 06/16] tty: serial: Add 8250-core based omap driver

2014-09-29 Thread Sebastian Andrzej Siewior
* Frans Klaver | 2014-09-29 11:38:23 [+0200]: threshold fixed +/* + * It claims to be 16C750 compatible however it is a little different. + * It has EFR and has no FCR7_64byte bit. The AFE (which it claims to + * have) is enabled via EFR instead of MCR. The type is set here

Re: [PATCH 06/16] tty: serial: Add 8250-core based omap driver

2014-09-29 Thread Frans Klaver
On Mon, Sep 29, 2014 at 3:27 PM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: * Frans Klaver | 2014-09-29 11:38:23 [+0200]: threshold fixed +/* + * It claims to be 16C750 compatible however it is a little different. + * It has EFR and has no FCR7_64byte bit. The AFE

Re: [PATCH 06/16] tty: serial: Add 8250-core based omap driver

2014-09-16 Thread Sebastian Andrzej Siewior
On 09/11/2014 01:57 PM, Peter Hurley wrote: Hi Sebastian, Hi Peter, Nice work. Minor comments within. Thanks. After this is merged, it may be worth investigating how to use Yoshihiro's newly-added 8250-based tunable RX trigger interface for omap. We need to overwrite the FCR callback.

Re: [PATCH 06/16] tty: serial: Add 8250-core based omap driver

2014-09-11 Thread Peter Hurley
Hi Sebastian, Nice work. Minor comments within. On 09/10/2014 03:30 PM, Sebastian Andrzej Siewior wrote: This patch provides a 8250-core based UART driver for the internal OMAP UART. The long term goal is to provide the same functionality as the current OMAP uart driver and DMA support. I

[PATCH 06/16] tty: serial: Add 8250-core based omap driver

2014-09-10 Thread Sebastian Andrzej Siewior
This patch provides a 8250-core based UART driver for the internal OMAP UART. The long term goal is to provide the same functionality as the current OMAP uart driver and DMA support. I tried to merge omap-serial code together with the 8250-core code. There should should be hardly a noticable