Re: [PATCH 07/15] twl4030_charger: allow fine control of charger current.

2015-03-07 Thread Sebastian Reichel
Hi Pavel, On Wed, Mar 04, 2015 at 11:24:15AM +0100, Pavel Machek wrote: (Now I'd need to study the datasheets... and figure out how to enable this on N900). The N900 uses bq24150a for charging ;) -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 07/15] twl4030_charger: allow fine control of charger current.

2015-03-04 Thread Pavel Machek
Hi! does this help? /* * For ichg_eoc, the hardware only supports reg values matching * 100000, and requires the be stored in the high nibble * of TWL4030_BCIMFTH8 */ A bit, yes. Add . at the end of sentence ;-). (Now I'd need to study the

Re: [PATCH 07/15] twl4030_charger: allow fine control of charger current.

2015-03-03 Thread NeilBrown
On Mon, 2 Mar 2015 22:05:01 +0100 Pavel Machek pa...@ucw.cz wrote: Hi! + /* ichg values in uA. If any are 'large', we set CGAIN to +* '1' which doubles the range for half the precision. +*/ + int ichg_eoc, ichg_lo, ichg_hi, cur; We should really get

Re: [PATCH 07/15] twl4030_charger: allow fine control of charger current.

2015-03-02 Thread Pavel Machek
Hi! + /* ichg values in uA. If any are 'large', we set CGAIN to + * '1' which doubles the range for half the precision. + */ + int ichg_eoc, ichg_lo, ichg_hi, cur; We should really get uA_t. [Plus, this is not kernel comment style, but...] + /*

[PATCH 07/15] twl4030_charger: allow fine control of charger current.

2015-02-23 Thread NeilBrown
The twl4030 allows control of the incoming current. Part of this control is a 'CGAIN' setting which doubles the range for half the precision. This control affects several different current setting, so all need to be updated at once when CGAIN is changed. With this patch, all of these current