Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-21 Thread George Cherian
On 8/21/2013 11:05 PM, Stephen Warren wrote: On 08/21/2013 07:06 AM, George Cherian wrote: Hi Stephen, On 8/20/2013 10:23 PM, Stephen Warren wrote: ID pins are connected to pcf8575, and the pcf8575's interrupt line is inturn connected to gpio bank6 pin 11, we use this gpio interrupt to detect

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-21 Thread Stephen Warren
On 08/21/2013 07:06 AM, George Cherian wrote: > Hi Stephen, > > On 8/20/2013 10:23 PM, Stephen Warren wrote: >>> >ID pins are connected to pcf8575, and the pcf8575's interrupt line is >>> >inturn connected to >>> >gpio bank6 pin 11, we use this gpio interrupt to detect the ID pin >>> change. >> In

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-21 Thread George Cherian
Hi Stephen, On 8/20/2013 10:23 PM, Stephen Warren wrote: >ID pins are connected to pcf8575, and the pcf8575's interrupt line is >inturn connected to >gpio bank6 pin 11, we use this gpio interrupt to detect the ID pin change. In that case, the PCF8575 node needs to be a GPIO controller and an IR

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Chanwoo Choi
> + > +if (dra7xx_usb->irq_gpio) { > +status = devm_request_threaded_irq(dra7xx_usb->dev, irq_num, > +NULL, id_irq_handler, IRQF_SHARED | > +IRQF_ONESHOT | IRQF_TRIGGER_FALLING, > +dev_name(&pdev->dev), (void *) dra

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Stephen Warren
On 08/20/2013 12:55 AM, George Cherian wrote: > Hi Stephen, > > Thanks for your review. > > On 8/20/2013 1:01 AM, Stephen Warren wrote: > >> On 08/16/2013 04:13 AM, George Cherian wrote: >>> Adding extcon driver for USB ID detection to dynamically >>> configure USB Host/Peripheral mode. >>> diff

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread George Cherian
On 8/20/2013 3:59 PM, Chanwoo Choi wrote: Hi George, diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt new file mode 100644 index 000..37e4c22 --- /dev/null +++ b/Documentation/devicetree/bindings/extcon/ext

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Chanwoo Choi
Hi George, >>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt >>> b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt >>> new file mode 100644 >>> index 000..37e4c22 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt >>> @@

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread George Cherian
Hi Chanwoo, Thanks for your review. On 8/20/2013 5:54 AM, Chanwoo Choi wrote: Hi George, On 08/16/2013 07:13 PM, George Cherian wrote: Adding extcon driver for USB ID detection to dynamically configure USB Host/Peripheral mode. Signed-off-by: George Cherian --- .../devicetree/bindings/ext

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-19 Thread George Cherian
Hi Stephen, Thanks for your review. On 8/20/2013 1:01 AM, Stephen Warren wrote: On 08/16/2013 04:13 AM, George Cherian wrote: Adding extcon driver for USB ID detection to dynamically configure USB Host/Peripheral mode. diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt b

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-19 Thread Chanwoo Choi
Hi George, On 08/16/2013 07:13 PM, George Cherian wrote: > Adding extcon driver for USB ID detection to dynamically > configure USB Host/Peripheral mode. > > Signed-off-by: George Cherian > --- > .../devicetree/bindings/extcon/extcon-dra7xx.txt | 19 ++ > drivers/extcon/Kconfig

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-19 Thread Stephen Warren
On 08/16/2013 04:13 AM, George Cherian wrote: > Adding extcon driver for USB ID detection to dynamically > configure USB Host/Peripheral mode. > diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt > b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt > +EXTCON FOR DR

[PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-16 Thread George Cherian
Adding extcon driver for USB ID detection to dynamically configure USB Host/Peripheral mode. Signed-off-by: George Cherian --- .../devicetree/bindings/extcon/extcon-dra7xx.txt | 19 ++ drivers/extcon/Kconfig | 7 + drivers/extcon/Makefile