Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

On Tue, Sep 01, 2015 at 11:56:06AM -0700, Tony Lindgren wrote: > * Mark Brown [150901 11:40]: > > That'd work. The other thing I was thinking we could do is to get > > syscon to treat any excessively large address that gets passed in that > > looks like an absolute address

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

* Mark Brown [150901 11:40]: > On Tue, Sep 01, 2015 at 07:17:21AM -0700, Tony Lindgren wrote: > > > Why don't you just make reg unused for pbias_regulator since > > we already use regmap for this driver? > > > Then in the pbias driver just define the register offset from > >

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

On Tue, Sep 01, 2015 at 07:17:21AM -0700, Tony Lindgren wrote: > Why don't you just make reg unused for pbias_regulator since > we already use regmap for this driver? > Then in the pbias driver just define the register offset from > the syscon base? You may need to set it based on the compatible

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

Hi Mark, On Monday 31 August 2015 08:22 PM, Mark Brown wrote: > On Mon, Aug 31, 2015 at 04:14:07PM +0530, Kishon Vijay Abraham I wrote: >> On Tuesday 25 August 2015 07:20 PM, Mark Brown wrote: >>> On Tue, Aug 25, 2015 at 01:03:04PM +0300, Grygorii Strashko wrote: On 08/19/2015 09:11 PM, Mark

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

Now fixed Lee Jones mail address! On Tuesday 01 September 2015 03:10 PM, Kishon Vijay Abraham I wrote: > Hi Mark, > > On Monday 31 August 2015 08:22 PM, Mark Brown wrote: >> On Mon, Aug 31, 2015 at 04:14:07PM +0530, Kishon Vijay Abraham I wrote: >>> On Tuesday 25 August 2015 07:20 PM, Mark Brown

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

Hi, I think the fix is rather easy here.. See below. * Kishon Vijay Abraham I [150901 02:43]: > > Before commit d919501feffa8715147582c3ffce96fad0c7016f ARM: dts: dra7: > add minimal l4 bus layout with control module support, the dt was like > > ocp { > dra7_ctrl_general:

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

On Mon, Aug 31, 2015 at 04:14:07PM +0530, Kishon Vijay Abraham I wrote: > On Tuesday 25 August 2015 07:20 PM, Mark Brown wrote: > > On Tue, Aug 25, 2015 at 01:03:04PM +0300, Grygorii Strashko wrote: > >> On 08/19/2015 09:11 PM, Mark Brown wrote: > >>> So substract this address from the start of

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

Hi Mark, On Tuesday 25 August 2015 07:20 PM, Mark Brown wrote: > On Tue, Aug 25, 2015 at 01:03:04PM +0300, Grygorii Strashko wrote: >> On 08/19/2015 09:11 PM, Mark Brown wrote: > >>> So substract this address from the start of the resource to get the >>> offset? Or provide a wrapper function in

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

On Tue, Aug 25, 2015 at 01:03:04PM +0300, Grygorii Strashko wrote: On 08/19/2015 09:11 PM, Mark Brown wrote: So substract this address from the start of the resource to get the offset? Or provide a wrapper function in the resource code which does that. I'd be very appreciated if you

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

Hi Mark, On 08/19/2015 09:11 PM, Mark Brown wrote: On Tue, Aug 18, 2015 at 11:23:54AM +0530, Kishon Vijay Abraham I wrote: On Friday 14 August 2015 11:30 PM, Mark Brown wrote: On Mon, Jul 27, 2015 at 04:54:09PM +0530, Kishon Vijay Abraham I wrote: is moved as a child node of syscon, vsel_reg

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

On Thu, Aug 20, 2015 at 11:21:06AM +0530, Kishon Vijay Abraham I wrote: On Wednesday 19 August 2015 11:41 PM, Mark Brown wrote: On Tue, Aug 18, 2015 at 11:23:54AM +0530, Kishon Vijay Abraham I wrote: Please fix your mail client to word wrap within paragraphs. platform_get_resource can be

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

On Tue, Aug 18, 2015 at 11:23:54AM +0530, Kishon Vijay Abraham I wrote: On Friday 14 August 2015 11:30 PM, Mark Brown wrote: On Mon, Jul 27, 2015 at 04:54:09PM +0530, Kishon Vijay Abraham I wrote: is moved as a child node of syscon, vsel_reg and enable_reg has the absolute address because

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

Hi Mark Brown, On Wednesday 19 August 2015 11:41 PM, Mark Brown wrote: On Tue, Aug 18, 2015 at 11:23:54AM +0530, Kishon Vijay Abraham I wrote: On Friday 14 August 2015 11:30 PM, Mark Brown wrote: On Mon, Jul 27, 2015 at 04:54:09PM +0530, Kishon Vijay Abraham I wrote: is moved as a child

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

Hi Mark Brown, On Friday 14 August 2015 11:30 PM, Mark Brown wrote: On Mon, Jul 27, 2015 at 04:54:09PM +0530, Kishon Vijay Abraham I wrote: vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon. However after the pbias device tree node I'm

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

On Mon, Jul 27, 2015 at 04:54:09PM +0530, Kishon Vijay Abraham I wrote: vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon. However after the pbias device tree node I'm having a hard time understanding this statement, sorry. What makes you

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

On 08/06/2015 09:26 AM, Tony Lindgren wrote: * Kishon Vijay Abraham I kis...@ti.com [150805 07:59]: Hi Tony, On Wednesday 05 August 2015 03:17 PM, Tony Lindgren wrote: * Kishon Vijay Abraham I kis...@ti.com [150727 04:27]: vsel_reg and enable_reg of the pbias regulator descriptor should

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

* Kishon Vijay Abraham I kis...@ti.com [150805 07:59]: Hi Tony, On Wednesday 05 August 2015 03:17 PM, Tony Lindgren wrote: * Kishon Vijay Abraham I kis...@ti.com [150727 04:27]: vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon. However

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

* Kishon Vijay Abraham I kis...@ti.com [150727 04:27]: vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon. However after the pbias device tree node is moved as a child node of syscon, vsel_reg and enable_reg has the absolute address because of

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

Hi Tony, On Wednesday 05 August 2015 03:17 PM, Tony Lindgren wrote: * Kishon Vijay Abraham I kis...@ti.com [150727 04:27]: vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon. However after the pbias device tree node is moved as a child node

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

On 07/27/2015 02:24 PM, Kishon Vijay Abraham I wrote: vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon. However after the pbias device tree node is moved as a child node of syscon, vsel_reg and enable_reg has the absolute address because of

[PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon. However after the pbias device tree node is moved as a child node of syscon, vsel_reg and enable_reg has the absolute address because of the address translation that happens while creating device