Re: [PATCH 1/2] staging: tidspbridge: rmgr/node.c code cleanup

2010-12-22 Thread Ramirez Luna, Omar
On Thu, Dec 9, 2010 at 3:47 PM, Ionut Nicu ionut.n...@gmail.com wrote: Reorganized some code in rmgr/node.c to increase its readability. Most of the changes reduce the code indentation level and simplifiy the code. No functional changes were done. Signed-off-by: Ionut Nicu

Re: [PATCH 1/2] staging: tidspbridge: rmgr/node.c code cleanup

2010-12-13 Thread Ramirez Luna, Omar
Hi, On Sun, Dec 12, 2010 at 8:20 AM, Ionut Nicu ionut.n...@mindbit.ro wrote: Are the other modes (rdma, zerocopy) not supported at all? No, those modes are not supported... the only one working for dsp streams is proc-copy. Is there any plan to make them work? If not, maybe the code that

Re: [PATCH 1/2] staging: tidspbridge: rmgr/node.c code cleanup

2010-12-12 Thread Ionut Nicu
Hi, On Thu, 2010-12-09 at 17:03 -0600, Ramirez Luna, Omar wrote: Hi Ionut, On Thu, Dec 9, 2010 at 4:22 PM, Ionut Nicu ionut.n...@mindbit.ro wrote: Hi Omar, On Thu, 2010-12-09 at 23:47 +0200, Ionut Nicu wrote: Reorganized some code in rmgr/node.c to increase its readability. Most of

[PATCH 1/2] staging: tidspbridge: rmgr/node.c code cleanup

2010-12-09 Thread Ionut Nicu
Reorganized some code in rmgr/node.c to increase its readability. Most of the changes reduce the code indentation level and simplifiy the code. No functional changes were done. Signed-off-by: Ionut Nicu ionut.n...@mindbit.ro --- drivers/staging/tidspbridge/rmgr/node.c | 607

Re: [PATCH 1/2] staging: tidspbridge: rmgr/node.c code cleanup

2010-12-09 Thread Ionut Nicu
Hi Omar, On Thu, 2010-12-09 at 23:47 +0200, Ionut Nicu wrote: Reorganized some code in rmgr/node.c to increase its readability. Most of the changes reduce the code indentation level and simplifiy the code. No functional changes were done. snip /* * Check stream mode. Default

Re: [PATCH 1/2] staging: tidspbridge: rmgr/node.c code cleanup

2010-12-09 Thread Felipe Contreras
On Fri, Dec 10, 2010 at 12:22 AM, Ionut Nicu ionut.n...@mindbit.ro wrote: I tried removing the first check and tested with the userspace-dspbridge strmcopy application, but I noticed the DSP hangs if I try to use it with anything else than the copy mode. Are the other modes (rdma, zerocopy)

Re: [PATCH 1/2] staging: tidspbridge: rmgr/node.c code cleanup

2010-12-09 Thread Ramirez Luna, Omar
Hi Ionut, On Thu, Dec 9, 2010 at 4:22 PM, Ionut Nicu ionut.n...@mindbit.ro wrote: Hi Omar, On Thu, 2010-12-09 at 23:47 +0200, Ionut Nicu wrote: Reorganized some code in rmgr/node.c to increase its readability. Most of the changes reduce the code indentation level and simplifiy the code. No