Re: [PATCH 1/2 v2] OMAP2/3: hwmod: fix the i2c-reset timeout during bootup

2011-04-16 Thread Kevin Hilman
On Mon, 2011-04-11 at 18:41 +0530, Avinash.H.M. wrote: + oh-_sysc_cache = v; + omap_hwmod_write(v, oh, oh-class-sysc-sysc_offs); Direct SYSCONFIG access isn't right here. This should go through omap_hwmod. What is probably needed is exposing _ocp_softreset to

Re: [PATCH 1/2 v2] OMAP2/3: hwmod: fix the i2c-reset timeout during bootup

2011-04-11 Thread Avinash.H.M.
+ oh-_sysc_cache = v; + omap_hwmod_write(v, oh, oh-class-sysc-sysc_offs); Direct SYSCONFIG access isn't right here. This should go through omap_hwmod. What is probably needed is exposing _ocp_softreset to device code via something like omap_hwmod_ocp_softreset() and

Re: [PATCH 1/2 v2] OMAP2/3: hwmod: fix the i2c-reset timeout during bootup

2011-04-07 Thread Avinash.H.M.
: Re: [PATCH 1/2 v2] OMAP2/3: hwmod: fix the i2c-reset timeout during bootup On Tue, Apr 5, 2011 at 11:57 PM, Kevin Hilman khil...@ti.com wrote: Avinash.H.M avinas...@ti.com writes: The i2c module has a special reset sequence. The sequence is - Disable the I2C. - Write to SOFTRESET bit

[PATCH 1/2 v2] OMAP2/3: hwmod: fix the i2c-reset timeout during bootup

2011-04-05 Thread Avinash.H.M
The i2c module has a special reset sequence. The sequence is - Disable the I2C. - Write to SOFTRESET bit. - Enable the I2C. - Poll on the RESETDONE bit. This sequence must be followed for i2c reset in omap2, omap3. The sequence is implemented as a function and the i2c_class is updated with the

Re: [PATCH 1/2 v2] OMAP2/3: hwmod: fix the i2c-reset timeout during bootup

2011-04-05 Thread Kevin Hilman
Avinash.H.M avinas...@ti.com writes: The i2c module has a special reset sequence. The sequence is - Disable the I2C. - Write to SOFTRESET bit. - Enable the I2C. - Poll on the RESETDONE bit. This sequence must be followed for i2c reset in omap2, omap3. The sequence is implemented as a