RE: [PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-03-05 Thread Govindarajan, Sriramakrishnan
-Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Saturday, February 27, 2010 2:30 PM To: Govindarajan, Sriramakrishnan Cc: Felipe Balbi; linux-omap@vger.kernel.org; linux-in...@vger.kernel.org Subject: Re: [PATCH 1/3] TCA6416 keypad : Implement

Re: [PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-02-27 Thread Dmitry Torokhov
; linux- in...@vger.kernel.org Subject: Re: [PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416 On Thu, Feb 25, 2010 at 08:47:03PM +0200, Felipe Balbi wrote: Hi, On Thu, Feb 25, 2010 at 06:44:59PM +0530, Sriramakrishnan wrote: This patch implements

Re: [PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-02-27 Thread Anirudh Ghayal
Hi, + +       chip = kzalloc(sizeof(struct tca6416_keypad_chip), GFP_KERNEL); +       if (chip == NULL) +               return -ENOMEM; Check for i2c functionality support ? +               ret = request_irq(chip-irqnum, tca6416_keys_isr, +                               IRQF_SHARED |

Re: [PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-02-26 Thread Dmitry Torokhov
On Thu, Feb 25, 2010 at 08:47:03PM +0200, Felipe Balbi wrote: Hi, On Thu, Feb 25, 2010 at 06:44:59PM +0530, Sriramakrishnan wrote: This patch implements a simple Keypad driver that functions as an I2C client. It handles key press events for keys connected to TCA6416 I2C based IO

RE: [PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-02-26 Thread Govindarajan, Sriramakrishnan
-Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Friday, February 26, 2010 1:58 PM To: Felipe Balbi Cc: Govindarajan, Sriramakrishnan; linux-omap@vger.kernel.org; linux- in...@vger.kernel.org Subject: Re: [PATCH 1/3] TCA6416 keypad : Implement

[PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-02-25 Thread Sriramakrishnan
This patch implements a simple Keypad driver that functions as an I2C client. It handles key press events for keys connected to TCA6416 I2C based IO expander. Signed-off-by: Sriramakrishnan s...@ti.com --- drivers/input/keyboard/Kconfig | 17 ++ drivers/input/keyboard/Makefile

Re: [PATCH 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-02-25 Thread Felipe Balbi
Hi, On Thu, Feb 25, 2010 at 06:44:59PM +0530, Sriramakrishnan wrote: This patch implements a simple Keypad driver that functions as an I2C client. It handles key press events for keys connected to TCA6416 I2C based IO expander. what's wrong with gpio-keys ?? + * Implementation based on