Re: [PATCH 1/3] video: fbdev: omap2: omapfb: remove __exit annotation

2014-10-15 Thread Felipe Balbi
Hi, On Wed, Oct 15, 2014 at 06:43:40PM +0300, Tomi Valkeinen wrote: > >> Somehow omapfb device is still unbound from the driver, as I can then > >> bind it again, causing probe to be called. Which breaks everything. > >> > >> I would've thought that unbinding is not possible if remove is missing,

Re: [PATCH 1/3] video: fbdev: omap2: omapfb: remove __exit annotation

2014-10-15 Thread Tomi Valkeinen
On 15/10/14 17:41, Felipe Balbi wrote: >> Interesting. I don't know if I'm doing something funny, but without this >> patch, I can unbind omapfb, kind of. >> >> "echo omapfb > unbind" goes ok, but remove is obviously not called. > > remove isn't called because it won't exist if it's built-in. Loo

Re: [PATCH 1/3] video: fbdev: omap2: omapfb: remove __exit annotation

2014-10-15 Thread Felipe Balbi
Hi, On Wed, Oct 15, 2014 at 03:13:34PM +0300, Tomi Valkeinen wrote: > Hi, > > On 14/10/14 21:28, Felipe Balbi wrote: > > if we leave __exit annotation, driver can't be unbound > > through sysfs. > > > > Signed-off-by: Felipe Balbi > > --- > > drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 4

Re: [PATCH 1/3] video: fbdev: omap2: omapfb: remove __exit annotation

2014-10-15 Thread Tomi Valkeinen
Hi, On 14/10/14 21:28, Felipe Balbi wrote: > if we leave __exit annotation, driver can't be unbound > through sysfs. > > Signed-off-by: Felipe Balbi > --- > drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video

[PATCH 1/3] video: fbdev: omap2: omapfb: remove __exit annotation

2014-10-14 Thread Felipe Balbi
if we leave __exit annotation, driver can't be unbound through sysfs. Signed-off-by: Felipe Balbi --- drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c b/drivers/video/fbdev/omap2