Re: [PATCH 1/9] omap: define _toggle_gpio_edge_triggering only for OMAP1

2010-02-03 Thread Tony Lindgren
* Uwe Kleine-König [100203 09:07]: > Hello Tony, > > On Wed, Feb 03, 2010 at 08:57:55AM -0800, Tony Lindgren wrote: > > BTW, looks like with "git show --pretty=email" the From: field gets > > messed up in the patch below. Author name shows OK in git though. > > > > I wonder if that's a git bug f

Re: [PATCH 1/9] omap: define _toggle_gpio_edge_triggering only for OMAP1

2010-02-03 Thread Uwe Kleine-König
Hello Tony, On Wed, Feb 03, 2010 at 08:57:55AM -0800, Tony Lindgren wrote: > BTW, looks like with "git show --pretty=email" the From: field gets > messed up in the patch below. Author name shows OK in git though. > > I wonder if that's a git bug for --pretty=email? Using version > 1.6.6.1 it seem

Re: [PATCH 1/9] omap: define _toggle_gpio_edge_triggering only for OMAP1

2010-02-03 Thread Tony Lindgren
* Uwe Kleine-König [100203 00:10]: > Hi Tony, > > On Tue, Feb 02, 2010 at 06:25:55PM -0800, Tony Lindgren wrote: > > From: Uwe Kleine-König > > > > The only usage of _toggle_gpio_edge_triggering is in an > > CONFIG_ARCH_OMAP1 is defined, too. > This sentence is broken, isn't it? I guess git co

Re: [PATCH 1/9] omap: define _toggle_gpio_edge_triggering only for OMAP1

2010-02-03 Thread Uwe Kleine-König
Hi Tony, On Tue, Feb 02, 2010 at 06:25:55PM -0800, Tony Lindgren wrote: > From: Uwe Kleine-König > > The only usage of _toggle_gpio_edge_triggering is in an > CONFIG_ARCH_OMAP1 is defined, too. This sentence is broken, isn't it? I guess git commit played tricks on me here and removed a line, so

[PATCH 1/9] omap: define _toggle_gpio_edge_triggering only for OMAP1

2010-02-02 Thread Tony Lindgren
From: Uwe Kleine-König The only usage of _toggle_gpio_edge_triggering is in an CONFIG_ARCH_OMAP1 is defined, too. This fixes a compiler warning: arch/arm/plat-omap/gpio.c:758: warning: '_toggle_gpio_edge_triggering' defined but not used when compiling for ARCH_OMAP2, ARCH_OMAP3 or ARC