Re: [PATCH 10/11] OMAP: GPIO: Implement GPIO as a platform device

2010-06-03 Thread Felipe Balbi
On Thu, Jun 03, 2010 at 08:58:25PM +0200, ext Kevin Hilman wrote: This doesn't look right for OMAP1. With a device name, you should just drop the "arm_cpio_ck" part, so you can do a clk_get(dev, NULL). I guess it doesn't matter. clkdev will try to match device and clk names, if that fails it

Re: [PATCH 10/11] OMAP: GPIO: Implement GPIO as a platform device

2010-06-03 Thread Kevin Hilman
Charulatha V writes: > This patch implements GPIO as a platform device. Also it > implements OMAP2PLUS specific GPIO as HWMOD FW adapted device. > > GPIO APIs are used in machine_init functions. Hence it is > required to complete GPIO probe before machine_init. Therefore > GPIO device register an

Re: [PATCH 10/11] OMAP: GPIO: Implement GPIO as a platform device

2010-05-20 Thread Kevin Hilman
"Cousson, Benoit" writes: > Hi Charu > >>From: Varadarajan, Charulatha >> >>> From: Cousson, Benoit >>> Sent: Tuesday, May 18, 2010 10:55 PM >>> >>> Hi Charu, >>> >>> On 5/18/2010 4:50 PM, Charulatha V wrote: >>> >>> [snip] >>> >>> > diff --git a/arch/arm/mach-omap2/clock2420_data.c b/arch/arm/ma

RE: [PATCH 10/11] OMAP: GPIO: Implement GPIO as a platform device

2010-05-19 Thread Cousson, Benoit
Hi Charu >From: Varadarajan, Charulatha > >> From: Cousson, Benoit >> Sent: Tuesday, May 18, 2010 10:55 PM >> >> Hi Charu, >> >> On 5/18/2010 4:50 PM, Charulatha V wrote: >> >> [snip] >> >> > diff --git a/arch/arm/mach-omap2/clock2420_data.c b/arch/arm/mach- >> omap2/clock2420_data.c >> > index d9

[PATCH 10/11] OMAP: GPIO: Implement GPIO as a platform device

2010-05-18 Thread Charulatha V
This patch implements GPIO as a platform device. Also it implements OMAP2PLUS specific GPIO as HWMOD FW adapted device. GPIO APIs are used in machine_init functions. Hence it is required to complete GPIO probe before machine_init. Therefore GPIO device register and driver register are implemented