Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-25 Thread NeilBrown
On Thu, 24 Apr 2014 15:19:14 +0100 One Thousand Gnomes gno...@lxorguk.ukuu.org.uk wrote: But I don't have discrete hardware. I have a bunch of stuff soldered onto a board with ad-hoc connections chosen to make the life of the hardware builder easy rather than chosen to make the

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-25 Thread Yegor Yefremov
On Fri, Apr 25, 2014 at 11:34 AM, NeilBrown ne...@suse.de wrote: On Thu, 24 Apr 2014 15:19:14 +0100 One Thousand Gnomes gno...@lxorguk.ukuu.org.uk wrote: But I don't have discrete hardware. I have a bunch of stuff soldered onto a board with ad-hoc connections chosen to make the life

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-25 Thread One Thousand Gnomes
As soon as this patch (http://www.spinics.net/lists/arm-kernel/msg325197.html) will be applied, we don't really need this DTR GPIO any more. For the omap specific case, not for the general case of sorting out power hierarchies. Alan -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-25 Thread One Thousand Gnomes
I had a quick look and I guess that uart_change_pm() is the most likely candidate for what you are referring to. I can see how that interfaces to the specific piece of uart hardware, such as omap-serial.c But I cannot see how you would plumb that though to the device that was plugged in to

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-24 Thread One Thousand Gnomes
But I don't have discrete hardware. I have a bunch of stuff soldered onto a board with ad-hoc connections chosen to make the life of the hardware builder easy rather than chosen to make the life of the software developer easy (which I think is the correct choice). So I need to

[PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Felipe Balbi
nobody passes a DTR_gpio to this driver, so this code is not necessary. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/tty/serial/omap-serial.c | 39 --- 1 file changed, 39 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Felipe Balbi
+Neil On Wed, Apr 23, 2014 at 09:58:34AM -0500, Felipe Balbi wrote: nobody passes a DTR_gpio to this driver, so this code is not necessary. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/tty/serial/omap-serial.c | 39 --- 1 file changed, 39

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Nishanth Menon
On 04/23/2014 09:58 AM, Felipe Balbi wrote: nobody passes a DTR_gpio to this driver, so this code is not necessary. Signed-off-by: Felipe Balbi ba...@ti.com --- Niel, this seems to revert the functionality introduced in commit 9574f36fb801035f6ab0fbb1b53ce2c12c17d100 (OMAP/serial: Add

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
On Wed, 23 Apr 2014 10:35:04 -0500 Nishanth Menon n...@ti.com wrote: On 04/23/2014 09:58 AM, Felipe Balbi wrote: nobody passes a DTR_gpio to this driver, so this code is not necessary. Signed-off-by: Felipe Balbi ba...@ti.com --- Niel, this seems to revert the functionality

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Felipe Balbi
Hi, On Thu, Apr 24, 2014 at 08:43:05AM +1000, NeilBrown wrote: On Wed, 23 Apr 2014 10:35:04 -0500 Nishanth Menon n...@ti.com wrote: On 04/23/2014 09:58 AM, Felipe Balbi wrote: nobody passes a DTR_gpio to this driver, so this code is not necessary. Signed-off-by: Felipe Balbi

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
On Wed, 23 Apr 2014 18:01:21 -0500 Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Apr 24, 2014 at 08:43:05AM +1000, NeilBrown wrote: On Wed, 23 Apr 2014 10:35:04 -0500 Nishanth Menon n...@ti.com wrote: On 04/23/2014 09:58 AM, Felipe Balbi wrote: nobody passes a DTR_gpio to this

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Felipe Balbi
Hi, On Thu, Apr 24, 2014 at 10:13:29AM +1000, NeilBrown wrote: On Wed, 23 Apr 2014 18:01:21 -0500 Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Apr 24, 2014 at 08:43:05AM +1000, NeilBrown wrote: On Wed, 23 Apr 2014 10:35:04 -0500 Nishanth Menon n...@ti.com wrote: On 04/23/2014

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
On Wed, 23 Apr 2014 20:21:00 -0500 Felipe Balbi ba...@ti.com wrote: I have no problem either way, just that unused code doesn't have to be sitting in the tree and I'm not entirely sure this GPIO should be handled by omap-serial.c, perhaps something more generic inside serial-core so other

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Felipe Balbi
Hi, On Thu, Apr 24, 2014 at 11:41:15AM +1000, NeilBrown wrote: On Wed, 23 Apr 2014 20:21:00 -0500 Felipe Balbi ba...@ti.com wrote: I have no problem either way, just that unused code doesn't have to be sitting in the tree and I'm not entirely sure this GPIO should be handled by

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
On Wed, 23 Apr 2014 20:43:34 -0500 Felipe Balbi ba...@ti.com wrote: so, Ack for $subject or not ? Just at the moment I'm finding it hard to care. So Acked-by: NeilBrown ne...@suse.de Whatever NeilBrown signature.asc Description: PGP signature