Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-10-01 Thread David Brownell
On Wednesday 01 October 2008, Jean Delvare wrote: > On Wed, 1 Oct 2008 08:58:12 -0700, David Brownell wrote: > > On Wednesday 01 October 2008, Felipe Contreras wrote: > > > Hmm, I'm seeing two different configs: > > > CONFIG_TWL4030_GPIO > > > CONFIG_GPIO_TWL4030 > > > > > > I guess the defconfigs

Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-10-01 Thread Jean Delvare
On Wed, 1 Oct 2008 08:58:12 -0700, David Brownell wrote: > On Wednesday 01 October 2008, Felipe Contreras wrote: > > Hmm, I'm seeing two different configs: > > CONFIG_TWL4030_GPIO > > CONFIG_GPIO_TWL4030 > > > > I guess the defconfigs are wrong. > > Right, they should get fixed. > > The same iss

Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-10-01 Thread David Brownell
On Wednesday 01 October 2008, Felipe Contreras wrote: > Hmm, I'm seeing two different configs: > CONFIG_TWL4030_GPIO > CONFIG_GPIO_TWL4030 > > I guess the defconfigs are wrong. Right, they should get fixed. The same issue will come when drivers/i2c/chips/twl4030-core.c moves to drivers/mfd/twl40

Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-10-01 Thread Felipe Balbi
On Wed, Oct 01, 2008 at 04:46:14PM +0300, ext Felipe Contreras wrote: > Hmm, I'm seeing two different configs: > CONFIG_TWL4030_GPIO dropped > CONFIG_GPIO_TWL4030 new one. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTE

Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-10-01 Thread Felipe Contreras
On Sun, Sep 28, 2008 at 8:16 AM, David Brownell <[EMAIL PROTECTED]> wrote: > On Saturday 27 September 2008, Felipe Balbi wrote: >> On Sat, Sep 27, 2008 at 04:45:20PM -0700, David Brownell wrote: >> > On Saturday 27 September 2008, Felipe Balbi wrote: >> > > We need something like the patch below (I

Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-09-27 Thread David Brownell
On Saturday 27 September 2008, Felipe Balbi wrote: > On Sat, Sep 27, 2008 at 04:45:20PM -0700, David Brownell wrote: > > On Saturday 27 September 2008, Felipe Balbi wrote: > > > We need something like the patch below (I can't find a substitute > > > to twl4030_set_gpio_edge_ctrl and twl4030_set_gpi

Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-09-27 Thread Felipe Balbi
On Sat, Sep 27, 2008 at 04:45:20PM -0700, David Brownell wrote: > On Saturday 27 September 2008, Felipe Balbi wrote: > > We need something like the patch below (I can't find a substitute > > to twl4030_set_gpio_edge_ctrl and twl4030_set_gpio_debounce): > > Something like that, yes. I have other p

Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-09-27 Thread David Brownell
On Saturday 27 September 2008, Felipe Balbi wrote: > We need something like the patch below (I can't find a substitute > to twl4030_set_gpio_edge_ctrl and twl4030_set_gpio_debounce): Something like that, yes. I have other patches queued up though. And meanwhile, your build seems goofed ... fix t

Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-09-27 Thread David Brownell
On Saturday 27 September 2008, Felipe Balbi wrote: > This patch breaks hsmmc.c: > arch/arm/mach-omap2/built-in.o: In function `hsmmc_card_detect': > /home/underline/workspace/linux-omap-2.6/arch/arm/mach-omap2/hsmmc.c:51: > undefined reference to `twl4030_get_gpio_datain' > ... etc Could yo

Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-09-27 Thread Felipe Balbi
On Sun, Sep 28, 2008 at 01:29:05AM +0300, Felipe Balbi wrote: > On Sat, Sep 27, 2008 at 02:41:40PM -0700, David Brownell wrote: > > From: David Brownell <[EMAIL PROTECTED]> > > > > Move the twl4030 GPIO support from drivers/i2c/chips to drivers/gpio, > > which is a more appropriate home for this c

Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-09-27 Thread Felipe Balbi
On Sat, Sep 27, 2008 at 02:41:40PM -0700, David Brownell wrote: > From: David Brownell <[EMAIL PROTECTED]> > > Move the twl4030 GPIO support from drivers/i2c/chips to drivers/gpio, > which is a more appropriate home for this code. > > The Kconfig symbol name is changed to match the GPIO_* convent

[PATCH 11/9] move twl4030-gpio to drivers/gpio

2008-09-27 Thread David Brownell
From: David Brownell <[EMAIL PROTECTED]> Move the twl4030 GPIO support from drivers/i2c/chips to drivers/gpio, which is a more appropriate home for this code. The Kconfig symbol name is changed to match the GPIO_* convention for such symbols, so config files must change in the obvious ways (Kconf