Re: [PATCH 12/17] spi/qspi: convert driver to enable/disable memory mapped.

2013-11-28 Thread Mark Brown
On Thu, Nov 28, 2013 at 10:54:12AM +0530, Sourav Poddar wrote: At the beginning of this api, I am doing a disable memory mapped, as becuase of the code implemntation, if the control has reaches this api, memory mapped is not the desired operation. Then, at the end of this api after

Re: [PATCH 12/17] spi/qspi: convert driver to enable/disable memory mapped.

2013-11-28 Thread Sourav Poddar
On Thursday 28 November 2013 04:19 PM, Mark Brown wrote: On Thu, Nov 28, 2013 at 10:54:12AM +0530, Sourav Poddar wrote: At the beginning of this api, I am doing a disable memory mapped, as becuase of the code implemntation, if the control has reaches this api, memory mapped is not the desired

Re: [PATCH 12/17] spi/qspi: convert driver to enable/disable memory mapped.

2013-11-28 Thread Mark Brown
On Thu, Nov 28, 2013 at 04:38:27PM +0530, Sourav Poddar wrote: On Thursday 28 November 2013 04:19 PM, Mark Brown wrote: Removing the mapping isn't going to stop another context which has obtained a handle on the map trying to look at the mapping. hmm..so the 'memcpy' part should be made

Re: [PATCH 12/17] spi/qspi: convert driver to enable/disable memory mapped.

2013-11-28 Thread Sourav Poddar
On Thursday 28 November 2013 05:29 PM, Mark Brown wrote: On Thu, Nov 28, 2013 at 04:38:27PM +0530, Sourav Poddar wrote: On Thursday 28 November 2013 04:19 PM, Mark Brown wrote: Removing the mapping isn't going to stop another context which has obtained a handle on the map trying to look at the

Re: [PATCH 12/17] spi/qspi: convert driver to enable/disable memory mapped.

2013-11-27 Thread Sourav Poddar
Hi Mark, On Tuesday 26 November 2013 06:41 PM, Mark Brown wrote: On Tue, Nov 26, 2013 at 01:05:08PM +0530, Sourav Poddar wrote: Idea is to enable memory mapped by default at the end of the probe, if the control reaches the transfer api, then the operation is not a memory mapped one. Hence, we

Re: [PATCH 12/17] spi/qspi: convert driver to enable/disable memory mapped.

2013-11-26 Thread Mark Brown
On Tue, Nov 26, 2013 at 01:05:08PM +0530, Sourav Poddar wrote: Idea is to enable memory mapped by default at the end of the probe, if the control reaches the transfer api, then the operation is not a memory mapped one. Hence, we switch to Normal mode and at the end of the transfer function.

[PATCH 12/17] spi/qspi: convert driver to enable/disable memory mapped.

2013-11-25 Thread Sourav Poddar
Idea is to enable memory mapped by default at the end of the probe, if the control reaches the transfer api, then the operation is not a memory mapped one. Hence, we switch to Normal mode and at the end of the transfer function. switch back to memory mapped mode. Signed-off-by: Sourav Poddar