Re: [PATCH 2/2] Add basic devices support for Nook Color

2011-04-29 Thread Felipe Balbi
On Thu, Apr 28, 2011 at 12:10:09PM -0400, Oleg Drokin wrote: Hello! On Apr 28, 2011, at 2:14 AM, Mike Rapoport wrote: +static struct omap_musb_board_data musb_board_data = { +.interface_type = MUSB_INTERFACE_ULPI, +#ifdef CONFIG_USB_MUSB_OTG +.mode

Re: [PATCH 2/2] Add basic devices support for Nook Color

2011-04-28 Thread Mike Rapoport
(adding Felipe to cc) Felipe, can you comment on the mUSB part, please? On 04/27/11 19:12, Oleg Drokin wrote: Hello! Thanks for the feedback. On Apr 27, 2011, at 4:49 AM, Mike Rapoport wrote: MMC/SD interface, i2c, usb. You should have added these at the first patch instead of Android

Re: [PATCH 2/2] Add basic devices support for Nook Color

2011-04-28 Thread Oleg Drokin
Hello! On Apr 28, 2011, at 2:14 AM, Mike Rapoport wrote: +static struct omap_musb_board_data musb_board_data = { + .interface_type = MUSB_INTERFACE_ULPI, +#ifdef CONFIG_USB_MUSB_OTG + .mode = MUSB_OTG, +#elif defined(CONFIG_USB_MUSB_HDRC_HCD) + .mode

Re: [PATCH 2/2] Add basic devices support for Nook Color

2011-04-27 Thread Mike Rapoport
On 04/27/11 04:52, gr...@linuxhacker.ru wrote: From: Oleg Drokin gr...@linuxhacker.ru MMC/SD interface, i2c, usb. You should have added these at the first patch instead of Android devices. --- arch/arm/configs/encore-nookcolor-defconfig | 2015 +++ The defconfig

Re: [PATCH 2/2] Add basic devices support for Nook Color

2011-04-27 Thread Oleg Drokin
Hello! Thanks for the feedback. On Apr 27, 2011, at 4:49 AM, Mike Rapoport wrote: MMC/SD interface, i2c, usb. You should have added these at the first patch instead of Android devices. So, basically you want all board file changes to come as a single patch, right? ---