Re: [PATCH 2/2] USB: musb: omap2430: add mode change from A to B

2010-07-22 Thread Kan-Ru Chen
On Thu, 22 Jul 2010 19:40:44 +0300, Felipe Balbi wrote: > On 07/22/2010 06:16 PM, Kan-Ru Chen wrote: > > Just curious about how to do this in a more automatic way. > > > > I think setup a daemon to monitor the musb_hdrc mode and try to alter > > it's state via sysfs interface will work, but it ma

Re: [PATCH 2/2] USB: musb: omap2430: add mode change from A to B

2010-07-22 Thread Felipe Balbi
On 07/22/2010 06:16 PM, Kan-Ru Chen wrote: > Just curious about how to do this in a more automatic way. > > I think setup a daemon to monitor the musb_hdrc mode and try to alter > it's state via sysfs interface will work, but it may be error prone and > not always desirable solution. > > Can we q

Re: [PATCH 2/2] USB: musb: omap2430: add mode change from A to B

2010-07-22 Thread Kan-Ru Chen
--text follows this line-- Hi, On Mon, 15 Mar 2010 18:23:42 +0800, Wang Hui wrote: > On omap2/3 series platforms, the musb can't raise id pin change > detection interrupt, so we must change otg mode through sysfs > interface manually. Currently when the musb is in B mode, if we > want musb to be

Re: [PATCH 2/2] USB: musb: omap2430: add mode change from A to B

2010-03-16 Thread Felipe Balbi
Hi, On Tue, Mar 16, 2010 at 06:13:50PM +0800, wanghui wrote: > Thank you for your comments. > It is right that in this function, we should only change id pin rules > according to user's choice, and > leave mode transition to the ISR. > But things are different on omap platforms, because the id pi

Re: [PATCH 2/2] USB: musb: omap2430: add mode change from A to B

2010-03-16 Thread wanghui
Felipe Balbi wrote: On Mon, Mar 15, 2010 at 02:22:38PM +0300, Sergei Shtylyov wrote: The whole musb_platform_set_mode() seems to be implemented incorrectly on OMAPs -- it shouldn't touch the DevCtl.Session bit. This correct. It should be changing the id pin rules just like in tusb6

Re: [PATCH 2/2] USB: musb: omap2430: add mode change from A to B

2010-03-15 Thread Felipe Balbi
On Mon, Mar 15, 2010 at 02:22:38PM +0300, Sergei Shtylyov wrote: >The whole musb_platform_set_mode() seems to be implemented > incorrectly on OMAPs -- it shouldn't touch the DevCtl.Session bit. This correct. It should be changing the id pin rules just like in tusb6010.c > function should co

Re: [PATCH 2/2] USB: musb: omap2430: add mode change from A to B

2010-03-15 Thread Sergei Shtylyov
Hello. Wang Hui wrote: On omap2/3 series platforms, the musb can't raise id pin change detection interrupt, so we must change otg mode through sysfs interface manually. Currently when the musb is in B mode, if we want musb to be changed to A mode, we should plug a mini-A cable and then execute

[PATCH 2/2] USB: musb: omap2430: add mode change from A to B

2010-03-15 Thread Wang Hui
On omap2/3 series platforms, the musb can't raise id pin change detection interrupt, so we must change otg mode through sysfs interface manually. Currently when the musb is in B mode, if we want musb to be changed to A mode, we should plug a mini-A cable and then execute echo host > /sys/devices/pl