* Felipe Balbi felipe.ba...@nokia.com [100310 23:26]:
hi,
On Wed, Mar 10, 2010 at 06:15:49PM +0100, ext Tony Lindgren wrote:
Updated patch below, is this what you want to do? Maybe reply with
an updated patch if you want usb_ehci_init not to use const?
I'm happy with your version.
OK
hi,
On Wed, Mar 10, 2010 at 06:15:49PM +0100, ext Tony Lindgren wrote:
Updated patch below, is this what you want to do? Maybe reply with
an updated patch if you want usb_ehci_init not to use const?
I'm happy with your version.
Also, there are other ehci related warnings, see the attached
* Felipe Balbi m...@felipebalbi.com [100309 06:27]:
Hi,
On Mon, Mar 08, 2010 at 03:04:23PM -0800, Tony Lindgren wrote:
Hmm yeah thanks for digging into this mystery. Looks like we're
hitting some Linux initdata limitation.
We can't mark everything as __initconst. Some platform data
On Tue, Mar 09, 2010 at 07:38:27AM -0800, Tony Lindgren wrote:
But sounds like your fix to mark anything going to init.rodata as const
is correct since it is rodata. I was originally thinking this is somehow
related to __init vs __initconst, but it's for __initconst only, and
we should use
Hi,
On Mon, Mar 08, 2010 at 03:04:23PM -0800, Tony Lindgren wrote:
Hmm yeah thanks for digging into this mystery. Looks like we're
hitting some Linux initdata limitation.
We can't mark everything as __initconst. Some platform data can
get dynamically set based on the board type for
* Felipe Balbi m...@felipebalbi.com [100309 07:44]:
On Tue, Mar 09, 2010 at 07:38:27AM -0800, Tony Lindgren wrote:
But sounds like your fix to mark anything going to init.rodata as const
is correct since it is rodata. I was originally thinking this is somehow
related to __init vs
Hi,
On Tue, Mar 09, 2010 at 04:48:27PM -0800, Tony Lindgren wrote:
[snip]
@@ -273,7 +273,7 @@ static void __init am3517_evm_init_irq(void)
omap_gpio_init();
}
-static struct ehci_hcd_omap_platform_data ehci_pdata __initdata = {
+static const struct ehci_hcd_omap_platform_data
* Felipe Balbi felipe.ba...@nokia.com [100304 23:00]:
On Thu, Mar 04, 2010 at 08:15:27PM +0100, ext m...@felipebalbi.com wrote:
Hi,
On Thu, 4 Mar 2010 18:33:15 +0530, Gadiyar, Anand gadi...@ti.com
wrote:
This patch fixes that for the ehci_hdc_omap_platform_data.
should be
felipe.ba...@nokia.com wrote:
From: Felipe Balbi felipe.ba...@nokia.com
the early_param() call in board-omap3touchbook.c expands to:
static const char __setup_str_early_touchbook_revision[]
__section(.init.rodata) _aligned(1) = tbr;
[...]
and we have a non-const variable being
Hi,
On Thu, 4 Mar 2010 18:33:15 +0530, Gadiyar, Anand gadi...@ti.com
wrote:
This patch fixes that for the ehci_hdc_omap_platform_data.
should be ehci_hcd_omap_platform_data ;)
BTW, this breaks compile for omap3-evm.
Could you please build with omap3_defconfig and check.
will do first
On Thu, Mar 04, 2010 at 08:15:27PM +0100, ext m...@felipebalbi.com wrote:
Hi,
On Thu, 4 Mar 2010 18:33:15 +0530, Gadiyar, Anand gadi...@ti.com
wrote:
This patch fixes that for the ehci_hdc_omap_platform_data.
should be ehci_hcd_omap_platform_data ;)
BTW, this breaks compile for omap3-evm.
From: Felipe Balbi felipe.ba...@nokia.com
the early_param() call in board-omap3touchbook.c expands to:
static const char __setup_str_early_touchbook_revision[]
__section(.init.rodata) _aligned(1) = tbr;
[...]
and we have a non-const variable being added to the
same section:
static
On Thu, Mar 04, 2010 at 08:40:16AM +0100, Balbi Felipe (Nokia-D/Helsinki) wrote:
From: Felipe Balbi felipe.ba...@nokia.com
the early_param() call in board-omap3touchbook.c expands to:
static const char __setup_str_early_touchbook_revision[]
__section(.init.rodata) _aligned(1) = tbr;
From: Felipe Balbi felipe.ba...@nokia.com
the early_param() call in board-omap3touchbook.c expands to:
static const char __setup_str_early_touchbook_revision[]
__section(.init.rodata) _aligned(1) = tbr;
[...]
and we have a non-const variable being added to the
same section:
static
14 matches
Mail list logo
