Re: [PATCH 2/2 V2] OMAP3+: PM: SR: add suspend/resume handlers

2011-08-04 Thread Kevin Hilman
Nishanth Menon writes: > SmartReflex should be disabled while entering low power mode due to > the following reasons: > a) SmartReflex values are not defined for retention voltage. > b) With SmartReflex enabled, if the CPU enters low power state, FSM >will try to bump the voltage to current O

Re: [PATCH 2/2 V2] OMAP3+: PM: SR: add suspend/resume handlers

2011-07-25 Thread Felipe Balbi
Hi, On Mon, Jul 25, 2011 at 12:55:39PM -0500, Menon, Nishanth wrote: > On Mon, Jul 25, 2011 at 12:13, Felipe Balbi wrote: > [..] > >> > while at that, SR's IRQ is never freed on exit path, could fix it while > >> > you're already there ? > >> > >> This is not really related to this patch is it? I

Re: [PATCH 2/2 V2] OMAP3+: PM: SR: add suspend/resume handlers

2011-07-25 Thread Menon, Nishanth
On Mon, Jul 25, 2011 at 12:13, Felipe Balbi wrote: [..] >> > while at that, SR's IRQ is never freed on exit path, could fix it while >> > you're already there ? >> >> This is not really related to this patch is it? IMHO IRQ handling is > > I didn't say to put it on the same patch ;-) I meant that

Re: [PATCH 2/2 V2] OMAP3+: PM: SR: add suspend/resume handlers

2011-07-25 Thread Felipe Balbi
Hi, On Mon, Jul 25, 2011 at 11:59:10AM -0500, Menon, Nishanth wrote: > > On Sun, Jul 24, 2011 at 11:52:37AM -0500, Nishanth Menon wrote: > >> SmartReflex should be disabled while entering low power mode due to > >> the following reasons: > >> a) SmartReflex values are not defined for retention vol

Re: [PATCH 2/2 V2] OMAP3+: PM: SR: add suspend/resume handlers

2011-07-25 Thread Menon, Nishanth
On Mon, Jul 25, 2011 at 03:42, Felipe Balbi wrote: > Hi, > > On Sun, Jul 24, 2011 at 11:52:37AM -0500, Nishanth Menon wrote: >> SmartReflex should be disabled while entering low power mode due to >> the following reasons: >> a) SmartReflex values are not defined for retention voltage. >> b) With S

Re: [PATCH 2/2 V2] OMAP3+: PM: SR: add suspend/resume handlers

2011-07-25 Thread Felipe Balbi
Hi, On Sun, Jul 24, 2011 at 11:52:37AM -0500, Nishanth Menon wrote: > SmartReflex should be disabled while entering low power mode due to > the following reasons: > a) SmartReflex values are not defined for retention voltage. > b) With SmartReflex enabled, if the CPU enters low power state, FSM >

[PATCH 2/2 V2] OMAP3+: PM: SR: add suspend/resume handlers

2011-07-24 Thread Nishanth Menon
SmartReflex should be disabled while entering low power mode due to the following reasons: a) SmartReflex values are not defined for retention voltage. b) With SmartReflex enabled, if the CPU enters low power state, FSM will try to bump the voltage to current OPP's voltage for which it has en