Hi Nishanth,
After some testing I have found a little problem with the init
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Menon, Nishanth
Refactor the smart reflex implementation.
[snip]
+ return ret;
+}
+late_initcall(omap_sr_init);
Hello Nishanth, Manjunath,
a comment on cpu_relax() and udelay().
On Mon, 26 Oct 2009, Menon, Nishanth wrote:
-Original Message-
From: G, Manjunath Kondaiah
As per your comments for other patches when ever there is udelay usage,
cpu_relax is the better option. I see there
ow...@vger.kernel.org] On Behalf Of Kalle Jokiniemi
Sent: Tuesday, October 27, 2009 5:14 PM
Hi Nishanth,
Found some dead code, see below:
[...]
+/* T2 SMART REFLEX */
+#define R_SRI2C_SLAVE_ADDR 0x12
+#define R_VDD1_SR_CONTROL 0x00
+#define
-Original Message-
ow...@vger.kernel.org] On Behalf Of Paul Walmsley
Sent: Wednesday, October 28, 2009 1:37 AM
[..]
a comment on cpu_relax() and udelay().
On Mon, 26 Oct 2009, Menon, Nishanth wrote:
-Original Message-
From: G, Manjunath Kondaiah
As per your
: RE: [PATCH 2/2 v3] OMAP3: PM: SR: SmartReflex Refactor Rev4.0
As per your comments for other patches when ever there is udelay usage,
cpu_relax is the better option. I see there are lot of udelay(...) calls
used in this patch. Why can't you use cpu_relax() or schedule().
Any specific reason
From: Nishanth Menon [mailto:menon.nisha...@gmail.com]
Cousson, Benoit said the following on 10/25/2009 05:12 PM:
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-
[...]
+ },
+ /* *INDENT-ON* */
+};
+
+/* SR list for 3430 */
+static __initdata
Subject: RE: [PATCH 2/2 v3] OMAP3: PM: SR: SmartReflex Refactor Rev4.0
-Original Message-
From: G, Manjunath Kondaiah
Sent: Monday, October 26, 2009 3:40 AM
To: Menon, Nishanth; linux-omap@vger.kernel.org
Cc: Imberton Guilhem; Mike Chan; Nayak, Rajendra; Roger
Quadros; Kalle
Walmsley; Hogander Jouni
Subject: RE: [PATCH 2/2 v3] OMAP3: PM: SR: SmartReflex Refactor Rev4.0
-Original Message-
From: G, Manjunath Kondaiah
Sent: Monday, October 26, 2009 3:40 AM
To: Menon, Nishanth; linux-omap@vger.kernel.org
Cc: Imberton Guilhem; Mike Chan; Nayak, Rajendra
From: Nishanth Menon [mailto:menon.nisha...@gmail.com] On Behalf Of Menon,
Nishanth
Benoit,
thanks.. overall good discussion that is nice to take in.. more comments
You're welcome! My pleasure.
follow:
Cousson, Benoit said the following on 10/26/2009 08:05 AM:
From: Nishanth Menon
Hi Nishanth,
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Menon, Nishanth
Refactor the smart reflex implementation.
[snip]
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-
omap2/smartreflex.c
new file mode 100644
index
Cousson, Benoit said the following on 10/25/2009 05:12 PM:
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-
[...]
+ },
+ /* *INDENT-ON* */
+};
+
+/* SR list for 3430 */
+static __initdata struct omap_sr_list omap34xx_srlist = {
+ .num_sr = 2,
+
11 matches
Mail list logo
