Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-10-31 Thread Valdis . Kletnieks
On Fri, 28 Oct 2011 15:03:36 +0300, Tero Kristo said: Hi Again, I created a new version of the patch which should be better than this hack, I'll send it as an RFC to the l-o list in a bit. On Thu, 2011-10-13 at 13:49 +0200, Munegowda, Keshava wrote: On Thu, Oct 13, 2011 at 4:58 PM, Tero

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-10-28 Thread Tero Kristo
...@vger.kernel.org; gadi...@ti.com; sa...@linux.intel.com; t...@atomide.com; khil...@ti.com; johns...@us.ibm.com; vishwanath...@ti.com Subject: Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3 On Sat, Sep 24, 2011 at 12:00 PM, Paul Walmsley p...@pwsan.com

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-10-28 Thread Munegowda, Keshava
: omap: usb: ehci and ohci hwmod structures for omap3 On Sat, Sep 24, 2011 at 12:00 PM, Paul Walmsley p...@pwsan.com wrote: On Fri, 23 Sep 2011, Munegowda, Keshava wrote: On Thu, Sep 22, 2011 at 11:31 PM, Paul Walmsley p...@pwsan.com wrote: But the question arises

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-10-13 Thread Munegowda, Keshava
...@vger.kernel.org; gadi...@ti.com; sa...@linux.intel.com; t...@atomide.com; khil...@ti.com; johns...@us.ibm.com; vishwanath...@ti.com Subject: Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3 On Sat, Sep 24, 2011 at 12:00 PM, Paul Walmsley p...@pwsan.com wrote

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-10-04 Thread Munegowda, Keshava
On Fri, Sep 30, 2011 at 11:46 PM, Paul Walmsley p...@pwsan.com wrote: On Fri, 30 Sep 2011, Munegowda, Keshava wrote: On Fri, Sep 30, 2011 at 2:02 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 28 Sep 2011, Munegowda, Keshava wrote: Thanks paul, But In USB Host case, there is a

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-30 Thread Paul Walmsley
On Wed, 28 Sep 2011, Munegowda, Keshava wrote: Thanks paul, But In USB Host case, there is a challenge! I need both usbhost_48m_fck and usbhost_120m_fck to be turned on when I invoke pm_runtime_get_sync ; so there are couple of options to do this 1. use clk_get with hard coded

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-30 Thread Munegowda, Keshava
On Fri, Sep 30, 2011 at 2:02 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 28 Sep 2011, Munegowda, Keshava wrote: Thanks paul, But In USB Host case, there is a challenge! I need both usbhost_48m_fck and usbhost_120m_fck to be turned on when I invoke pm_runtime_get_sync ; so there are

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-30 Thread Paul Walmsley
On Fri, 30 Sep 2011, Munegowda, Keshava wrote: On Fri, Sep 30, 2011 at 2:02 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 28 Sep 2011, Munegowda, Keshava wrote: Thanks paul, But In USB Host case, there is a challenge! I need both usbhost_48m_fck and usbhost_120m_fck to be turned

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-28 Thread Munegowda, Keshava
On Mon, Sep 26, 2011 at 8:15 PM, Paul Walmsley p...@pwsan.com wrote: On Mon, 26 Sep 2011, Munegowda, Keshava wrote: On Sat, Sep 24, 2011 at 12:45 PM, Paul Walmsley p...@pwsan.com wrote: On Fri, 23 Sep 2011, Munegowda, Keshava wrote: On Thu, Sep 22, 2011 at 11:31 PM, Paul Walmsley

RE: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-27 Thread Partha Basak
; gadi...@ti.com; sa...@linux.intel.com; t...@atomide.com; khil...@ti.com; johns...@us.ibm.com; vishwanath...@ti.com Subject: Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3 On Sat, Sep 24, 2011 at 12:00 PM, Paul Walmsley p...@pwsan.com wrote: On Fri, 23 Sep 2011

RE: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-27 Thread Tero Kristo
2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3 On Sat, Sep 24, 2011 at 12:00 PM, Paul Walmsley p...@pwsan.com wrote: On Fri, 23 Sep 2011, Munegowda, Keshava wrote: On Thu, Sep 22, 2011 at 11:31 PM, Paul Walmsley p...@pwsan.com wrote: But the question arises here

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-27 Thread Munegowda, Keshava
...@ti.com; johns...@us.ibm.com; vishwanath...@ti.com Subject: Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3 On Sat, Sep 24, 2011 at 12:00 PM, Paul Walmsley p...@pwsan.com wrote: On Fri, 23 Sep 2011, Munegowda, Keshava wrote: On Thu, Sep 22, 2011 at 11:31 PM

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-27 Thread Felipe Balbi
Hi, On Tue, Sep 27, 2011 at 06:48:35PM +0530, Munegowda, Keshava wrote: So, you would need a mechanism to do something like this: pad a or b wakeup detected - irq0 pad c or d wakeup detected - irq1? yes, if get something like this , its perfect. can't you have different IRQs for each

RE: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-27 Thread Partha Basak
; linux-ker...@vger.kernel.org; Gadiyar, Anand; sa...@linux.intel.com; t...@atomide.com; Hilman, Kevin; johns...@us.ibm.com; Sripathy, Vishwanath Subject: Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3 Hi, On Tue, Sep 27, 2011 at 06:48:35PM +0530, Munegowda, Keshava wrote

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-27 Thread Tero Kristo
On Tue, 2011-09-27 at 15:24 +0200, Balbi, Felipe wrote: Hi, On Tue, Sep 27, 2011 at 06:48:35PM +0530, Munegowda, Keshava wrote: So, you would need a mechanism to do something like this: pad a or b wakeup detected - irq0 pad c or d wakeup detected - irq1? yes, if get something

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-27 Thread Felipe Balbi
hi, On Tue, Sep 27, 2011 at 05:38:51PM +0300, Tero Kristo wrote: On Tue, Sep 27, 2011 at 06:48:35PM +0530, Munegowda, Keshava wrote: So, you would need a mechanism to do something like this: pad a or b wakeup detected - irq0 pad c or d wakeup detected - irq1? yes, if get

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-26 Thread Munegowda, Keshava
On Sat, Sep 24, 2011 at 12:00 PM, Paul Walmsley p...@pwsan.com wrote: On Fri, 23 Sep 2011, Munegowda, Keshava wrote: On Thu, Sep 22, 2011 at 11:31 PM, Paul Walmsley p...@pwsan.com wrote: But the question arises here , why do we need these ehci and ohci as two different hwmods containing only

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-26 Thread Munegowda, Keshava
On Sat, Sep 24, 2011 at 12:45 PM, Paul Walmsley p...@pwsan.com wrote: On Fri, 23 Sep 2011, Munegowda, Keshava wrote: On Thu, Sep 22, 2011 at 11:31 PM, Paul Walmsley p...@pwsan.com wrote: On Thu, 22 Sep 2011, Keshava Munegowda wrote: 4. usb_tll_hs hwmod of usbhs with the TLL base address

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-26 Thread Paul Walmsley
On Mon, 26 Sep 2011, Munegowda, Keshava wrote: On Sat, Sep 24, 2011 at 12:45 PM, Paul Walmsley p...@pwsan.com wrote: On Fri, 23 Sep 2011, Munegowda, Keshava wrote: On Thu, Sep 22, 2011 at 11:31 PM, Paul Walmsley p...@pwsan.com wrote: On Thu, 22 Sep 2011, Keshava Munegowda wrote:

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-24 Thread Paul Walmsley
On Fri, 23 Sep 2011, Munegowda, Keshava wrote: On Thu, Sep 22, 2011 at 11:31 PM, Paul Walmsley p...@pwsan.com wrote: But the question arises here , why do we need these ehci and ohci as two different hwmods containing only irq and base address? It is required for future - to implement

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-24 Thread Paul Walmsley
On Fri, 23 Sep 2011, Munegowda, Keshava wrote: On Thu, Sep 22, 2011 at 11:31 PM, Paul Walmsley p...@pwsan.com wrote: On Thu, 22 Sep 2011, Keshava Munegowda wrote: 4. usb_tll_hs hwmod of usbhs with the TLL base address and irq. Signed-off-by: Keshava Munegowda keshava_mgo...@ti.com

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-23 Thread Munegowda, Keshava
On Thu, Sep 22, 2011 at 11:31 PM, Paul Walmsley p...@pwsan.com wrote: Hi a few comments On Thu, 22 Sep 2011, Keshava Munegowda wrote: following 4 hwmod structures are added 1. usb_host_hs hwmod of usbhs with uhh base address and functional clock, 2. usb_ehci_hs hwmod with irq and base

[PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-22 Thread Keshava Munegowda
following 4 hwmod structures are added 1. usb_host_hs hwmod of usbhs with uhh base address and functional clock, 2. usb_ehci_hs hwmod with irq and base address, 3. usb_ohci_hs hwmod with irq and base address, - the ehci and ohci hwmods does not require functional clock because

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

2011-09-22 Thread Paul Walmsley
Hi a few comments On Thu, 22 Sep 2011, Keshava Munegowda wrote: following 4 hwmod structures are added 1. usb_host_hs hwmod of usbhs with uhh base address and functional clock, 2. usb_ehci_hs hwmod with irq and base address, 3. usb_ohci_hs hwmod with irq and base address, - the ehci