[PATCH 3/3] ARM: OMAP: dma: Fix the kfree ordering

2013-06-13 Thread Rajendra Nayak
kfree of 'p' followed by kfree of 'd' where d = p-dma_attr certainly seems wrong. Results in a Oops when probe fails and ends up at exit_dma_lch_fail: [0.612579] Unable to handle kernel NULL pointer dereference at virtual address 0048 [0.620971] pgd = c0004000 [0.623840]

Re: [PATCH 3/3] ARM: OMAP: dma: Fix the kfree ordering

2013-06-13 Thread Russell King - ARM Linux
On Thu, Jun 13, 2013 at 06:39:20PM +0530, Rajendra Nayak wrote: diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 8a71f75..8e16503 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -2111,8 +2111,8 @@ exit_dma_irq_fail: }

Re: [PATCH 3/3] ARM: OMAP: dma: Fix the kfree ordering

2013-06-13 Thread Rajendra Nayak
On Thursday 13 June 2013 06:46 PM, Russell King - ARM Linux wrote: On Thu, Jun 13, 2013 at 06:39:20PM +0530, Rajendra Nayak wrote: diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 8a71f75..8e16503 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@