Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-18 Thread Paul Walmsley
On Wed, 18 Nov 2009, Tony Lindgren wrote: > To me it sounds like this can wait until the merge window, > so not adding to omap-fixes for now. Indeed, there's no rush on this one, so let's set it up for 2.6.33. I'll keep that macro in plat/system.h unless you or Russell have a better suggestion.

Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-18 Thread Tony Lindgren
; > >Sent: Tuesday, November 17, 2009 11:39 AM > > >To: Russell King - ARM Linux > > >Cc: linux-arm-ker...@lists.infradead.org; Juha Leppänen; > > >linux-omap@vger.kernel.org > > >Subject: Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors > > &g

Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-17 Thread Tony Lindgren
sell King - ARM Linux > >Cc: linux-arm-ker...@lists.infradead.org; Juha Leppänen; > >linux-omap@vger.kernel.org > >Subject: Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors > > > > >+/** > >+ * omap_test_timeout - busy-loop, testing a condition > >+ *

RE: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-17 Thread Pandita, Vikram
eppänen; >linux-omap@vger.kernel.org >Subject: Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors > >+/** >+ * omap_test_timeout - busy-loop, testing a condition >+ * @cond: condition to test until it evaluates to true >+ * @timeout: maximum number of microseconds in th

Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-17 Thread Paul Walmsley
Hi Russell, On Mon, 16 Nov 2009, Russell King - ARM Linux wrote: > On Mon, Nov 16, 2009 at 06:36:55AM -0700, Paul Walmsley wrote: > > Fix loop bailout off-by-one bugs reported by Juha Leppänen > > . > > I'm not sure the new code is any easier to read than the old code. > And what with some check

Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-16 Thread Russell King - ARM Linux
On Mon, Nov 16, 2009 at 06:36:55AM -0700, Paul Walmsley wrote: > Fix loop bailout off-by-one bugs reported by Juha Leppänen > . I'm not sure the new code is any easier to read than the old code. And what with some checks post-loop being <= and others being >, it's a recipe for cut'n'paste errors h

[PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-16 Thread Paul Walmsley
Fix loop bailout off-by-one bugs reported by Juha Leppänen . Signed-off-by: Paul Walmsley Cc: Juha Leppänen --- arch/arm/mach-omap2/cm.c |2 +- arch/arm/mach-omap2/omap_hwmod.c | 12 +--- arch/arm/mach-omap2/prcm.c |4 ++-- 3 files changed, 8 insertions(+), 10 de