On Thu, Sep 04, 2008 at 07:48:02AM -0700, Steve Sakoman wrote:
On Thu, Sep 4, 2008 at 5:04 AM, Mark Brown [EMAIL PROTECTED] wrote:
Normally SND_SOC_BIAS_STANDBY would leave Vmid enabled but your power
down function turns it off. The normal thing here is to have standby
bring the codec up
On Thu, Sep 04, 2008 at 07:32:28AM -0700, Steve Sakoman wrote:
On Thu, Sep 4, 2008 at 3:26 AM, Jarkko Nikula [EMAIL PROTECTED] wrote:
+static void twl4030_dump_registers(void)
+{
This is not needed since there is already nice function
for it: sound/soc/soc-core.c: codec_reg_show.
I
On Fri, Sep 5, 2008 at 3:06 AM, Mark Brown [EMAIL PROTECTED] wrote:
How about I add a TODO on this? I'm swamped for the next few weeks
and won't be able to give it the attention it deserves test-wise.
If there aren't any bypass paths then it should be fine to leave it
as-is.
There are no
On Fri, Sep 5, 2008 at 3:30 AM, Mark Brown [EMAIL PROTECTED] wrote:
On Thu, Sep 04, 2008 at 07:32:28AM -0700, Steve Sakoman wrote:
On Thu, Sep 4, 2008 at 3:26 AM, Jarkko Nikula [EMAIL PROTECTED] wrote:
I could probably get rid of this function. It was quite useful during
debugging and I was
From: Steve Sakoman [EMAIL PROTECTED]
SOUND: SOC: CODECS: Add support for the TWL4030 audio codec
This version should take into account all feedback received to date
Signed-off-by: Steve Sakoman [EMAIL PROTECTED]
---
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index
On Fri, Sep 05, 2008 at 07:34:00AM -0700, Steve Sakoman wrote:
From: Steve Sakoman [EMAIL PROTECTED]
Looks good.
Acked-by: Mark Brown [EMAIL PROTECTED]
SOUND: SOC: CODECS: Add support for the TWL4030 audio codec
Usually it'd be formatted as
ALSA: ASoC: Add support for TWL4030 audio codec
On Fri, Sep 5, 2008 at 7:48 AM, Mark Brown [EMAIL PROTECTED] wrote:
Looks good.
Acked-by: Mark Brown [EMAIL PROTECTED]
SOUND: SOC: CODECS: Add support for the TWL4030 audio codec
Usually it'd be formatted as
ALSA: ASoC: Add support for TWL4030 audio codec
Thanks Mark!
I'll change the
On Wed, 3 Sep 2008 22:01:58 -0700
ext [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
From: Steve Sakoman [EMAIL PROTECTED]
---
sound/soc/codecs/Kconfig |5 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/twl4030.c | 628 +++
...
+static void
On Wed, Sep 03, 2008 at 10:01:58PM -0700, [EMAIL PROTECTED] wrote:
+static void twl4030_power_up(struct snd_soc_codec *codec)
+{
+ u8 mode, byte, popn, hsgain;
+
+ /* set CODECPDZ to turn on codec */
+ mode = twl4030_read_reg_cache(codec, REG_CODEC_MODE);
+
On Thu, Sep 04, 2008 at 01:26:32PM +0300, Jarkko Nikula wrote:
+static void twl4030_dump_registers(void)
+{
This is not needed since there is already nice function
for it: sound/soc/soc-core.c: codec_reg_show.
It's doing something slighly different and dumping the chip registers
rather
On Thu, Sep 4, 2008 at 3:26 AM, Jarkko Nikula [EMAIL PROTECTED] wrote:
On Wed, 3 Sep 2008 22:01:58 -0700
ext [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
+static void twl4030_dump_registers(void)
+{
This is not needed since there is already nice function
for it: sound/soc/soc-core.c:
On Thu, Sep 4, 2008 at 5:04 AM, Mark Brown [EMAIL PROTECTED] wrote:
On Wed, Sep 03, 2008 at 10:01:58PM -0700, [EMAIL PROTECTED] wrote:
+ /* initiate offset cancellation */
+ twl4030_write(codec, REG_ANAMICL,
+ twl4030_reg[REG_ANAMICL] | CNCL_OFFSET_START);
It looks a bit
From: Steve Sakoman [EMAIL PROTECTED]
---
sound/soc/codecs/Kconfig |5 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/twl4030.c | 628
sound/soc/codecs/twl4030.h | 197 ++
4 files changed, 832 insertions(+), 0 deletions(-)
13 matches
Mail list logo
