Re: [PATCH 3/6] OMAP4460: Temperature sensor data

2011-09-25 Thread J, KEERTHY
On Sat, Sep 24, 2011 at 1:18 PM, Paul Walmsley wrote: > On Fri, 23 Sep 2011, J, KEERTHY wrote: > >> On Fri, Sep 23, 2011 at 11:33 AM, Paul Walmsley wrote: >> > >> > On Thu, 22 Sep 2011, Keerthy wrote: >> > >> >> @@ -0,0 +1,175 @@ >> >> +/* >> >> + * OMAP system control module header file >> >> +

Re: [PATCH 3/6] OMAP4460: Temperature sensor data

2011-09-24 Thread J, KEERTHY
On Sat, Sep 24, 2011 at 1:29 PM, Paul Walmsley wrote: > On Fri, 23 Sep 2011, J, KEERTHY wrote: > >> On Fri, Sep 23, 2011 at 11:33 AM, Paul Walmsley wrote: >> >> > On Thu, 22 Sep 2011, Keerthy wrote: >> > >> >> diff --git a/arch/arm/mach-omap2/temp_sensor4460_data.c >> >> b/arch/arm/mach-omap2/te

Re: [PATCH 3/6] OMAP4460: Temperature sensor data

2011-09-24 Thread Paul Walmsley
On Fri, 23 Sep 2011, J, KEERTHY wrote: > On Fri, Sep 23, 2011 at 11:33 AM, Paul Walmsley wrote: > > > On Thu, 22 Sep 2011, Keerthy wrote: > > > >> diff --git a/arch/arm/mach-omap2/temp_sensor4460_data.c > >> b/arch/arm/mach-omap2/temp_sensor4460_data.c > >> new file mode 100644 > >> index 00

Re: [PATCH 3/6] OMAP4460: Temperature sensor data

2011-09-24 Thread Paul Walmsley
On Fri, 23 Sep 2011, J, KEERTHY wrote: > On Fri, Sep 23, 2011 at 11:33 AM, Paul Walmsley wrote: > > > > On Thu, 22 Sep 2011, Keerthy wrote: > > > >> @@ -0,0 +1,175 @@ > >> +/* > >> + * OMAP system control module header file > >> + * > >> + * Copyright (C) 2011 Texas Instruments Incorporated - htt

Re: [PATCH 3/6] OMAP4460: Temperature sensor data

2011-09-23 Thread J, KEERTHY
On Fri, Sep 23, 2011 at 11:33 AM, Paul Walmsley wrote: > Hi > > some comments > > On Thu, 22 Sep 2011, Keerthy wrote: > >> The register set and the >> bit fields might vary across OMAP versions. Hence >> creating a structure comprising of all the registers >> and bit fields to make the driver unif

Re: [PATCH 3/6] OMAP4460: Temperature sensor data

2011-09-22 Thread Paul Walmsley
Hi some comments On Thu, 22 Sep 2011, Keerthy wrote: > The register set and the > bit fields might vary across OMAP versions. Hence > creating a structure comprising of all the registers > and bit fields to make the driver uniform for all the > versions with different register sets. The data fil

[PATCH 3/6] OMAP4460: Temperature sensor data

2011-09-22 Thread Keerthy
The register set and the bit fields might vary across OMAP versions. Hence creating a structure comprising of all the registers and bit fields to make the driver uniform for all the versions with different register sets. The data file contains the structure populated with register offsets and bit f