* Peter Ujfalusi peter.ujfal...@ti.com [110603 16:34]:
On Friday 03 June 2011 11:08:22 Tony Lindgren wrote:
Yeah if it gets big then a separate file is better. Also, if we have
a common init function for twl, then it's easy to add the board specific
device tree initialization to that too
* Peter Ujfalusi peter.ujfal...@ti.com [110602 09:11]:
On Wednesday 01 June 2011 16:38:23 Tony Lindgren wrote:
But you could easily remove all the board specific struct
twl4030_codec_data and struct twl4030_codec_audio_data entries by adding a
default audio init option to omap_pmic_init for
On Friday 03 June 2011 11:08:22 Tony Lindgren wrote:
Yeah if it gets big then a separate file is better. Also, if we have
a common init function for twl, then it's easy to add the board specific
device tree initialization to that too and just leave out the calls to
omap_pmic_init from
On Wednesday 01 June 2011 16:38:23 Tony Lindgren wrote:
But you could easily remove all the board specific struct
twl4030_codec_data and struct twl4030_codec_audio_data entries by adding a
default audio init option to omap_pmic_init for the common configuration.
Yeah, I can grep in the board
Allign the platform data names for twl4030 audio submodule:
twl4030_audio_data: for the core MFD driver
twl4030_codec_data: for ASoC codec driver
twl4030_vibra_data: for the input/ForceFeedback driver
To avoid breakage, change all depending drivers, files
to use the new types.
Signed-off-by:
* Peter Ujfalusi peter.ujfal...@ti.com [110601 04:14]:
--- a/arch/arm/mach-omap2/board-3430sdp.c
+++ b/arch/arm/mach-omap2/board-3430sdp.c
@@ -463,11 +463,11 @@ static struct regulator_init_data sdp3430_vpll2 = {
.consumer_supplies = sdp3430_vpll2_supplies,
};
-static struct
On Wednesday 01 June 2011 15:07:54 Tony Lindgren wrote:
Can you please take a look at creating arch/arm/mach-omap2/i2c-twl.c or
something in common-board-devices.c to get rid of the cut and paste
duplication in every board-*.c file?
Yes, it would make sense, since most of the board has
* Peter Ujfalusi peter.ujfal...@ti.com [110601 05:50]:
On Wednesday 01 June 2011 15:07:54 Tony Lindgren wrote:
Can you please take a look at creating arch/arm/mach-omap2/i2c-twl.c or
something in common-board-devices.c to get rid of the cut and paste
duplication in every board-*.c file?
On Wednesday 01 June 2011 16:00:34 Tony Lindgren wrote:
Yeah, most of it might be possible to describe with just a flags
like TWL_HAS_VIBRA etc.
Or TWL_BOARD_HAS_VIBRA, TWL_BOARD_HAS_CODEC...
For the audio part it is a bit complicated than that:
different base frequencies, for twl6040 we have
* Peter Ujfalusi peter.ujfal...@ti.com [110601 06:13]:
On Wednesday 01 June 2011 16:00:34 Tony Lindgren wrote:
Yeah, most of it might be possible to describe with just a flags
like TWL_HAS_VIBRA etc.
Or TWL_BOARD_HAS_VIBRA, TWL_BOARD_HAS_CODEC...
For the audio part it is a bit
10 matches
Mail list logo
