Re: [PATCH 4/4] omap: musb: introduce default baord config

2011-05-03 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [110502 07:22]: On Mon, May 02, 2011 at 07:20:52AM -0700, Tony Lindgren wrote: * Oleg Drokin gr...@linuxhacker.ru [110428 09:33]: So to me it looks like something totally in realm of musb driver itself. Nothing bad happens if you configure your MUSB as say

Re: [PATCH 4/4] omap: musb: introduce default baord config

2011-05-02 Thread Tony Lindgren
* Oleg Drokin gr...@linuxhacker.ru [110428 09:33]: Hello! On Apr 28, 2011, at 12:28 PM, Russell King - ARM Linux wrote: mm, it looks to me like we're ending up with two layers on top of each other, both trying to provide some kind of generic board interface. I think they should be

Re: [PATCH 4/4] omap: musb: introduce default baord config

2011-05-02 Thread Felipe Balbi
On Mon, May 02, 2011 at 07:20:52AM -0700, Tony Lindgren wrote: * Oleg Drokin gr...@linuxhacker.ru [110428 09:33]: Hello! On Apr 28, 2011, at 12:28 PM, Russell King - ARM Linux wrote: mm, it looks to me like we're ending up with two layers on top of each other, both trying to provide

Re: [PATCH 4/4] omap: musb: introduce default baord config

2011-04-28 Thread Russell King - ARM Linux
On Wed, Apr 27, 2011 at 12:23:18AM -0400, Oleg Drokin wrote: Hello! On Apr 24, 2011, at 6:09 PM, Mike Rapoport wrote: -void __init usb_musb_init(struct omap_musb_board_data *board_data) +static struct omap_musb_board_data musb_default_board_data = { + .interface_type =

Re: [PATCH 4/4] omap: musb: introduce default baord config

2011-04-28 Thread Oleg Drokin
Hello! On Apr 28, 2011, at 10:18 AM, Russell King - ARM Linux wrote: -void __init usb_musb_init(struct omap_musb_board_data *board_data) +static struct omap_musb_board_data musb_default_board_data = { + .interface_type = MUSB_INTERFACE_ULPI, + .mode = MUSB_OTG,

Re: [PATCH 4/4] omap: musb: introduce default baord config

2011-04-28 Thread Russell King - ARM Linux
On Thu, Apr 28, 2011 at 12:21:47PM -0400, Oleg Drokin wrote: Frankly, I am not even sure why the mode needs to be supplied by the board at all. The musb code already has a very similar switch in musb_plat and so it totally looks like a duplicated specification of the same thing from the

Re: [PATCH 4/4] omap: musb: introduce default baord config

2011-04-28 Thread Oleg Drokin
Hello! On Apr 28, 2011, at 12:28 PM, Russell King - ARM Linux wrote: mm, it looks to me like we're ending up with two layers on top of each other, both trying to provide some kind of generic board interface. I think they should be squashed together. And that: static struct

Re: [PATCH 4/4] omap: musb: introduce default baord config

2011-04-27 Thread Mike Rapoport
On 04/27/11 07:23, Oleg Drokin wrote: Hello! On Apr 24, 2011, at 6:09 PM, Mike Rapoport wrote: -void __init usb_musb_init(struct omap_musb_board_data *board_data) +static struct omap_musb_board_data musb_default_board_data = { +.interface_type = MUSB_INTERFACE_ULPI, +.mode

Re: [PATCH 4/4] omap: musb: introduce default baord config

2011-04-26 Thread Oleg Drokin
Hello! On Apr 24, 2011, at 6:09 PM, Mike Rapoport wrote: -void __init usb_musb_init(struct omap_musb_board_data *board_data) +static struct omap_musb_board_data musb_default_board_data = { + .interface_type = MUSB_INTERFACE_ULPI, + .mode = MUSB_OTG, In fact

[PATCH 4/4] omap: musb: introduce default baord config

2011-04-24 Thread Mike Rapoport
Most boards use exactly the same configuration for musb initialization. Create a default that can be shared amount different boards. Signed-off-by: Mike Rapoport m...@compulab.co.il --- arch/arm/mach-omap2/board-2430sdp.c |7 +-- arch/arm/mach-omap2/board-3430sdp.c |