Re: [PATCH 4/6] omap iommu: simple virtual address space management

2009-05-18 Thread Hiroshi DOYU
Hi Russell, From: ext Russell King - ARM Linux li...@arm.linux.org.uk Subject: Re: [PATCH 4/6] omap iommu: simple virtual address space management Date: Sat, 16 May 2009 11:22:48 +0200 On Tue, May 05, 2009 at 03:47:06PM +0300, Hiroshi DOYU wrote: +int ioremap_page(unsigned long virt, unsigned

Re: [PATCH 4/6] omap iommu: simple virtual address space management

2009-05-18 Thread Russell King - ARM Linux
On Mon, May 18, 2009 at 09:31:26AM +0300, Hiroshi DOYU wrote: Right. In this change for better performance, I have to expose struct mem_type and get_mem_type() a bit more as below. Is this change acceptable, or do you have a better idea? You don't need to expose struct mem_type at all. You

Re: [PATCH 4/6] omap iommu: simple virtual address space management

2009-05-16 Thread Russell King - ARM Linux
On Tue, May 05, 2009 at 03:47:06PM +0300, Hiroshi DOYU wrote: +int ioremap_page(unsigned long virt, unsigned long phys, unsigned int mtype) +{ + const struct mem_type *type; + + type = get_mem_type(mtype); + if (!type) + return -EINVAL; I think it would make more

[PATCH 4/6] omap iommu: simple virtual address space management

2009-05-05 Thread Hiroshi DOYU
This patch provides a device drivers, which has a omap iommu, with address mapping APIs between device virtual address(iommu), physical address and MPU virtual address. There are 4 possible patterns for iommu virtual address(iova/da) mapping. |iova/mapping

Re: [PATCH 4/6] omap iommu: simple virtual address space management

2009-01-27 Thread Hiroshi DOYU
Hi Russell, Thank you for your reivew. I attached the update one. From: ext Russell King - ARM Linux li...@arm.linux.org.uk Subject: Re: [PATCH 4/6] omap iommu: simple virtual address space management Date: Sat, 17 Jan 2009 17:57:26 +0100 [...] Lastly, I'm not entirely sold on the four

Re: [PATCH 4/6] omap iommu: simple virtual address space management

2009-01-17 Thread Russell King - ARM Linux
On Fri, Jan 16, 2009 at 10:37:25AM +0200, Hiroshi DOYU wrote: +static struct iovm_struct *__find_iovm_area(struct iommu *obj, const void *_da) +{ + struct iovm_struct *tmp; + u32 da = (u32)_da; ... +static struct iovm_struct *alloc_iovm_area(struct iommu *obj, void *da, +

[PATCH 4/6] omap iommu: simple virtual address space management

2009-01-16 Thread Hiroshi DOYU
This patch provides a device drivers, which has a omap iommu, with address mapping APIs between device virtual address(iommu), physical address and MPU virtual address. There are 4 possible patterns for iommu virtual address(iova/da) mapping. |iova/mapping