RE: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul

2010-08-03 Thread Ramos Falcon, Ernesto
...@vger.kernel.org; Menon, Nishanth; linux-omap@vger.kernel.org Subject: Re: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul On Wed, Jul 28, 2010 at 5:40 PM, Ernesto Ramos erne...@ti.com wrote: Replace simple_strtoul by strict_strtoul in atoi function. In general

[PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul

2010-07-28 Thread Ernesto Ramos
Replace simple_strtoul by strict_strtoul in atoi function. Signed-off-by: Ernesto Ramos erne...@ti.com --- drivers/staging/tidspbridge/rmgr/dbdcd.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/staging/tidspbridge/rmgr/dbdcd.c

Re: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul

2010-07-28 Thread Greg KH
On Wed, Jul 28, 2010 at 09:40:52AM -0500, Ernesto Ramos wrote: Replace simple_strtoul by strict_strtoul in atoi function. Why not use the built-in kernel function instead of having your own atoi function? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul

2010-07-28 Thread Andy Shevchenko
On Wed, Jul 28, 2010 at 6:09 PM, Greg KH gre...@suse.de wrote: On Wed, Jul 28, 2010 at 09:40:52AM -0500, Ernesto Ramos wrote: Replace simple_strtoul by strict_strtoul in atoi function. Why not use the built-in kernel function instead of having your own atoi function? The commit message left

Re: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul

2010-07-28 Thread Andy Shevchenko
On Wed, Jul 28, 2010 at 5:40 PM, Ernesto Ramos erne...@ti.com wrote: Replace simple_strtoul by strict_strtoul in atoi function. In general the question what is the purpose here to do the change? @@ -1023,7 +1025,9 @@ static s32 atoi(char *psz_buf)                base = 16;        } -      

Re: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul

2010-07-28 Thread Greg KH
On Wed, Jul 28, 2010 at 09:40:19PM +0300, Andy Shevchenko wrote: On Wed, Jul 28, 2010 at 6:09 PM, Greg KH gre...@suse.de wrote: On Wed, Jul 28, 2010 at 09:40:52AM -0500, Ernesto Ramos wrote: Replace simple_strtoul by strict_strtoul in atoi function. Why not use the built-in kernel