Re: [PATCH 6/7] omap: iommu: remove unused exported API

2011-08-18 Thread Hiroshi DOYU
Hi Ohad, Just small question inlined From: ext Ohad Ben-Cohen o...@wizery.com Subject: [PATCH 6/7] omap: iommu: remove unused exported API Date: Thu, 18 Aug 2011 02:10:07 +0300 Remove unused public APIs from OMAP's iommu driver. IOMMU functionality should be exposed only via the generic

Re: [PATCH 6/7] omap: iommu: remove unused exported API

2011-08-18 Thread Ohad Ben-Cohen
Hi Hiroshi, On Thu, Aug 18, 2011 at 1:49 PM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: -extern void iommu_set_twl(struct iommu *obj, bool on); This function was introduced by Hari Kanigeri for some OMAP4 case, which is only using TLB, not H/W table walk. We discussed that internally, and

Re: [PATCH 6/7] omap: iommu: remove unused exported API

2011-08-18 Thread David Cohen
Hi Ohad, On Thu, Aug 18, 2011 at 2:01 PM, Ohad Ben-Cohen o...@wizery.com wrote: Hi Hiroshi, On Thu, Aug 18, 2011 at 1:49 PM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: -extern void iommu_set_twl(struct iommu *obj, bool on); This function was introduced by Hari Kanigeri for some OMAP4 case,

Re: [PATCH 6/7] omap: iommu: remove unused exported API

2011-08-18 Thread Ohad Ben-Cohen
Hi David, On Thu, Aug 18, 2011 at 4:40 PM, David Cohen daco...@gmail.com wrote: Not sure if David or anyone is using this, but if someone is, it must be out-of-tree. I am fine to remove it. OK, thanks for confirming! Ohad. -- To unsubscribe from this list: send the line unsubscribe

[PATCH 6/7] omap: iommu: remove unused exported API

2011-08-17 Thread Ohad Ben-Cohen
Remove unused public APIs from OMAP's iommu driver. IOMMU functionality should be exposed only via the generic IOMMU API; this way drivers stay generic, and different IOMMU drivers don't need to duplicate similar functionalities. The rest of the API still exposed by OMAP's iommu will be