Re: [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2

2009-10-19 Thread Eduardo Valentin
Hi, On Mon, Oct 12, 2009 at 11:21:04AM +0200, Mark Brown wrote: On Mon, Oct 12, 2009 at 12:04:55PM +0300, Eduardo Valentin wrote: Right. Should we add 4 instances of drvdd and 2 of iovdd? So, naming those would be like: No, if there's multiple pins for the supply then there's no need

Re: [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2

2009-10-19 Thread Mark Brown
On Mon, Oct 19, 2009 at 12:13:00PM +0300, Eduardo Valentin wrote: [Please fix your MUA to wrap before 80 columns.] Might be a stupid question probably because of my lack of knowledge of regulator framework, but if the driver code must be written in such a way that it requires all regulators

Re: [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2

2009-10-19 Thread Mark Brown
On Mon, Oct 19, 2009 at 10:23:32AM +0100, Mark Brown wrote: On Mon, Oct 19, 2009 at 12:13:00PM +0300, Eduardo Valentin wrote: Might be a stupid question probably because of my lack of knowledge of regulator framework, but if the driver code must be written in such a way that it requires

Re: [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2

2009-10-12 Thread Eduardo Valentin
On Thu, Oct 08, 2009 at 03:26:19PM +0200, Mark Brown wrote: On Thu, Oct 08, 2009 at 02:58:55PM +0300, Eduardo Valentin wrote: +static struct regulator_consumer_supply rx51_vmmc2_supplies[] = { + REGULATOR_SUPPLY(avdd_dac, 2-0018), /* tlv320aic3x */ + REGULATOR_SUPPLY(vdd, 2-0060), /*

Re: [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2

2009-10-12 Thread Mark Brown
On Mon, Oct 12, 2009 at 12:04:55PM +0300, Eduardo Valentin wrote: Right. Should we add 4 instances of drvdd and 2 of iovdd? So, naming those would be like: No, if there's multiple pins for the supply then there's no need to represent those individually - they're required to be wired together

[PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2

2009-10-08 Thread Eduardo Valentin
From: Eduardo Valentin eduardo.valen...@nokia.com This patch adds two supplies for VMMC2 on rx51 boards. Signed-off-by: Eduardo Valentin eduardo.valen...@nokia.com --- arch/arm/mach-omap2/board-rx51-peripherals.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff

Re: [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2

2009-10-08 Thread Mark Brown
On Thu, Oct 08, 2009 at 02:58:55PM +0300, Eduardo Valentin wrote: +static struct regulator_consumer_supply rx51_vmmc2_supplies[] = { + REGULATOR_SUPPLY(avdd_dac, 2-0018), /* tlv320aic3x */ + REGULATOR_SUPPLY(vdd, 2-0060), /* tpa6130a2*/ }; avdd_dac is the only supply added for the