Re: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-26 Thread FUJITA Tomonori
On Wed, 30 Jun 2010 19:20:59 -0500 Fernando Guzman Lugo x0095...@ti.com wrote: due to a restriction in scatter gather lists, it can not be created a list for a buffer bigger than 1MB. This patch is spliting big mappings into 1MB mappings. I don't read the whole thread but the above

Re: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-26 Thread Felipe Contreras
On Wed, Aug 25, 2010 at 10:42 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: On Wed, Aug 25, 2010 at 7:00 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: Or the whole iovmm.c can be copied and just remove the mapping. That is the migration patches do, remove custom bridge

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-26 Thread Guzman Lugo, Fernando
...@nokia.com; felipe.contre...@nokia.com Subject: Re: [PATCH 8/9] dspbridge: add map support for big buffers On Wed, 30 Jun 2010 19:20:59 -0500 Fernando Guzman Lugo x0095...@ti.com wrote: due to a restriction in scatter gather lists, it can not be created a list for a buffer bigger than 1MB. This patch

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-26 Thread FUJITA Tomonori
On Thu, 26 Aug 2010 07:38:26 -0500 Guzman Lugo, Fernando fernando.l...@ti.com wrote: due to a restriction in scatter gather lists, it can not be created a list for a buffer bigger than 1MB. This patch is spliting big mappings into 1MB mappings. I don't read the whole thread but the above

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-26 Thread Guzman Lugo, Fernando
...@nokia.com; felipe.contre...@nokia.com Subject: Re: [PATCH 8/9] dspbridge: add map support for big buffers On Wed, Aug 25, 2010 at 10:42 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: On Wed, Aug 25, 2010 at 7:00 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: Or the whole iovmm.c can

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-26 Thread Guzman Lugo, Fernando
; ameya.pala...@nokia.com; felipe.contre...@nokia.com Subject: RE: [PATCH 8/9] dspbridge: add map support for big buffers On Thu, 26 Aug 2010 07:38:26 -0500 Guzman Lugo, Fernando fernando.l...@ti.com wrote: due to a restriction in scatter gather lists, it can not be created a list for a buffer

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-26 Thread FUJITA Tomonori
On Thu, 26 Aug 2010 08:16:24 -0500 Guzman Lugo, Fernando fernando.l...@ti.com wrote: From a quick look, arch/arm/plat-omap/iovmm.c does nothing wrong about scatter gather chaining. arm/arm/mm/dma-mapping.c looks fine too about it. Maybe just defining ARCH_HAS_SG_CHAIN works? I can try, but

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-26 Thread Guzman Lugo, Fernando
; ameya.pala...@nokia.com; felipe.contre...@nokia.com Subject: RE: [PATCH 8/9] dspbridge: add map support for big buffers On Thu, 26 Aug 2010 08:16:24 -0500 Guzman Lugo, Fernando fernando.l...@ti.com wrote: From a quick look, arch/arm/plat-omap/iovmm.c does nothing wrong about scatter gather

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-25 Thread Guzman Lugo, Fernando
...@nokia.com; felipe.contre...@nokia.com Subject: Re: [PATCH 8/9] dspbridge: add map support for big buffers On Wed, Aug 25, 2010 at 12:55 AM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: However, from what I can see iovmm can be used instead of dmm even if the switch to iommu

Re: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-25 Thread Felipe Contreras
On Wed, Aug 25, 2010 at 7:00 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: Or the whole iovmm.c can be copied and just remove the mapping. That is the migration patches do, remove custom bridge mapping and use iovmm module instead. You didn't get me; copy the iovmm.c code into dmm.c,

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-25 Thread Guzman Lugo, Fernando
...@nokia.com; felipe.contre...@nokia.com Subject: Re: [PATCH 8/9] dspbridge: add map support for big buffers On Wed, Aug 25, 2010 at 7:00 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: Or the whole iovmm.c can be copied and just remove the mapping. That is the migration patches do

Re: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-24 Thread Felipe Contreras
On Fri, Jul 2, 2010 at 9:39 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: I think, it would be good if we get rid of DMMPOOL size, if the liked list grow up as it is needed, there is no memory penalty of have all the possible iommu addresses valid (1100 - ). The

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-24 Thread Guzman Lugo, Fernando
...@nokia.com; felipe.contre...@nokia.com Subject: Re: [PATCH 8/9] dspbridge: add map support for big buffers On Fri, Jul 2, 2010 at 9:39 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: I think, it would be good if we get rid of DMMPOOL size, if the liked list grow up as it is needed

Re: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-24 Thread Felipe Contreras
-ker...@vger.kernel.org; o...@wizery.com; hiroshi.d...@nokia.com; ameya.pala...@nokia.com; felipe.contre...@nokia.com Subject: Re: [PATCH 8/9] dspbridge: add map support for big buffers On Fri, Jul 2, 2010 at 9:39 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: I think, it would be good

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-24 Thread Guzman Lugo, Fernando
...@nokia.com; felipe.contre...@nokia.com Subject: Re: [PATCH 8/9] dspbridge: add map support for big buffers On Tue, Aug 24, 2010 at 7:31 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: -Original Message- From: Felipe Contreras [mailto:felipe.contre...@gmail.com] Sent

Re: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-24 Thread Felipe Contreras
On Tue, Aug 24, 2010 at 9:44 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: However, I still have the question about the dependency on iommu; AFAICS the DMM removal doesn't depend on the migration to iommu, which AFAIK has been stalled for some time. Yeah, DMM removal does not depend

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-24 Thread Guzman Lugo, Fernando
...@nokia.com; felipe.contre...@nokia.com Subject: Re: [PATCH 8/9] dspbridge: add map support for big buffers On Tue, Aug 24, 2010 at 9:44 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: However, I still have the question about the dependency on iommu; AFAICS the DMM removal doesn't

Re: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-24 Thread Felipe Contreras
On Tue, Aug 24, 2010 at 10:05 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: I've heard there are some problems regarding DMM, and since you say you have already done the changes, and since iommu migration is not yet ready AFAIK, it might make sense to go for option b). Anyway, thanks

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-24 Thread Guzman Lugo, Fernando
...@nokia.com; felipe.contre...@nokia.com Subject: Re: [PATCH 8/9] dspbridge: add map support for big buffers On Tue, Aug 24, 2010 at 10:05 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: I've heard there are some problems regarding DMM, and since you say you have already done

Re: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-24 Thread Felipe Contreras
On Tue, Aug 24, 2010 at 10:30 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: Oh, I actually meant the DMM pool. a) 1. Migrate to iommu, 2. Remove DMM completely b) 1. Remove DMM pool, 2. Migrate to iommu 3. Remove DMM completely Ok, what is the issue with DMM pool? From what I've

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-08-24 Thread Guzman Lugo, Fernando
...@nokia.com; felipe.contre...@nokia.com Subject: Re: [PATCH 8/9] dspbridge: add map support for big buffers On Tue, Aug 24, 2010 at 10:30 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: Oh, I actually meant the DMM pool. a) 1. Migrate to iommu, 2. Remove DMM completely b) 1

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-07-02 Thread Guzman Lugo, Fernando
Lugo, Fernando Subject: RE: [PATCH 8/9] dspbridge: add map support for big buffers Fernando, - for_each_sg(sgt-sgl, sg, sgt-nents, i) - sg_set_page(sg, usr_pgs[i], PAGE_SIZE, 0); + da = iommu_vmap(mmu, da, sgt, IOVMF_ENDIAN_LITTLE

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-07-02 Thread Kanigeri, Hari
: [PATCH 8/9] dspbridge: add map support for big buffers Hi Hari, -Original Message- From: Kanigeri, Hari Sent: Thursday, July 01, 2010 6:36 PM To: Guzman Lugo, Fernando; linux-omap@vger.kernel.org; linux- ker...@vger.kernel.org Cc: o...@wizery.com; hiroshi.d...@nokia.com

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-07-02 Thread Guzman Lugo, Fernando
: [PATCH 8/9] dspbridge: add map support for big buffers Fernando, -Original Message- From: Guzman Lugo, Fernando Sent: Friday, July 02, 2010 11:27 AM To: Kanigeri, Hari; linux-omap@vger.kernel.org; linux- ker...@vger.kernel.org Cc: o...@wizery.com; hiroshi.d...@nokia.com

RE: [PATCH 8/9] dspbridge: add map support for big buffers

2010-07-01 Thread Kanigeri, Hari
Fernando, - for_each_sg(sgt-sgl, sg, sgt-nents, i) - sg_set_page(sg, usr_pgs[i], PAGE_SIZE, 0); + da = iommu_vmap(mmu, da, sgt, IOVMF_ENDIAN_LITTLE | + IOVMF_ELSZ_32); -- iommu_vmap does the Kernel mapping to the

[PATCH 8/9] dspbridge: add map support for big buffers

2010-06-30 Thread Fernando Guzman Lugo
due to a restriction in scatter gather lists, it can not be created a list for a buffer bigger than 1MB. This patch is spliting big mappings into 1MB mappings. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- arch/arm/plat-omap/include/dspbridge/dsp-mmu.h |2 +-