Re: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c

Hello Russell, On Sat, 31 Jan 2009, Russell King - ARM Linux wrote: On Fri, Jan 30, 2009 at 08:23:49AM -0600, Woodruff, Richard wrote: There's one bug that your version highlights in mine - the virtual mpu clock in omap1 touches the DPLL and repropagates that rate. I've removed

Re: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c

Hi Russell, On Sat, 31 Jan 2009, Russell King - ARM Linux wrote: On Fri, Jan 30, 2009 at 08:23:49AM -0600, Woodruff, Richard wrote: There's one bug that your version highlights in mine - the virtual mpu clock in omap1 touches the DPLL and repropagates that rate. I've removed that

Re: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c

On Mon, Feb 02, 2009 at 12:13:02AM -0700, Paul Walmsley wrote: Based on a comparison of E 08 with the three omap-clks1 commits you mentioned above, here are some differences that would merit further attention. Some of these you've mentioned in subsequent E-mails. If you use your patches,

Re: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c

Hello Russell, On Fri, 30 Jan 2009, Paul Walmsley wrote: On Thu, 29 Jan 2009, Russell King - ARM Linux wrote: I must say that this commit looks very much like a combination of my commits from November: [ARM] omap: move clock propagation into core omap clock code [ARM] omap: remove

Re: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c

On Fri, Jan 30, 2009 at 08:23:49AM -0600, Woodruff, Richard wrote: There's one bug that your version highlights in mine - the virtual mpu clock in omap1 touches the DPLL and repropagates that rate. I've removed that repropagation, so that needs fixing. However, this raises a question:

Re: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c

Hello Russell, On Thu, 29 Jan 2009, Russell King - ARM Linux wrote: On Wed, Jan 28, 2009 at 12:27:51PM -0700, Paul Walmsley wrote: Previously the individual clock recalculation functions handled their own rate recalculation. This can be handled in the clk_set_rate(), clk_set_parent(),

Re: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c

On Fri, Jan 30, 2009 at 01:42:52AM -0700, Paul Walmsley wrote: I haven't looked closely at your above three patches for this, but plan to do so later today. Regarding provenance, the patches that I sent you were developed independently, for clock notifier support. Ultimately, I have no

RE: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c

There's one bug that your version highlights in mine - the virtual mpu clock in omap1 touches the DPLL and repropagates that rate. I've removed that repropagation, so that needs fixing. However, this raises a question: why is the virtual mpu clock touching some other part of the clock

Re: [PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c

On Wed, Jan 28, 2009 at 12:27:51PM -0700, Paul Walmsley wrote: Previously the individual clock recalculation functions handled their own rate recalculation. This can be handled in the clk_set_rate(), clk_set_parent(), and recalculate_root_clocks() functions in plat-omap/clock.c. Removes

[PATCH E 08/14] OMAP clock: move rate recalc, propagation code up to plat-omap/clock.c

Previously the individual clock recalculation functions handled their own rate recalculation. This can be handled in the clk_set_rate(), clk_set_parent(), and recalculate_root_clocks() functions in plat-omap/clock.c. Removes duplicate code and clarifies the role of the recalc functions.