Re: [PATCH V2 3/3] mfd: palmas: Add support for optional wakeup

2014-09-18 Thread Nishanth Menon
On 09/08/2014 10:41 AM, Nishanth Menon wrote: On 23:13-20140905, Thomas Gleixner wrote: On Fri, 5 Sep 2014, Nishanth Menon wrote: + if (!palmas-wakeirq) + goto no_wake_irq; + + ret = devm_request_irq(palmas-dev, palmas-wakeirq, + palmas_wake_irq, +

Re: [PATCH V2 3/3] mfd: palmas: Add support for optional wakeup

2014-09-18 Thread Lee Jones
On Thu, 18 Sep 2014, Nishanth Menon wrote: On 09/08/2014 10:41 AM, Nishanth Menon wrote: On 23:13-20140905, Thomas Gleixner wrote: On Fri, 5 Sep 2014, Nishanth Menon wrote: + if (!palmas-wakeirq) + goto no_wake_irq; + + ret = devm_request_irq(palmas-dev, palmas-wakeirq, +

Re: [PATCH V2 3/3] mfd: palmas: Add support for optional wakeup

2014-09-08 Thread Nishanth Menon
On 23:13-20140905, Thomas Gleixner wrote: On Fri, 5 Sep 2014, Nishanth Menon wrote: + if (!palmas-wakeirq) + goto no_wake_irq; + + ret = devm_request_irq(palmas-dev, palmas-wakeirq, + palmas_wake_irq, + IRQF_ONESHOT |

[PATCH V2 3/3] mfd: palmas: Add support for optional wakeup

2014-09-05 Thread Nishanth Menon
With the recent pinctrl-single changes, omaps can treat wake-up events from deeper power states as interrupts. This is to handle the case where the system needs two interrupt sources when SoC is in deep sleep(1 to exit from deep power mode such as sleep, and other from the module handling the

Re: [PATCH V2 3/3] mfd: palmas: Add support for optional wakeup

2014-09-05 Thread Thomas Gleixner
On Fri, 5 Sep 2014, Nishanth Menon wrote: + if (!palmas-wakeirq) + goto no_wake_irq; + + ret = devm_request_irq(palmas-dev, palmas-wakeirq, +palmas_wake_irq, +IRQF_ONESHOT | pdata-irq_flags, Why is this marked