Re: [PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-22 Thread Wolfram Sang
Can you comment on this ? As of today i2c-based drivers will probe with DT-based boot if DT's compatible is set to the same id as in struct i2c_device_id. No i2c driver with of_device_id can autoprobe using OF ids. Long standing problem. Last one to tackle this was Lee Jones:

Re: [PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-21 Thread Felipe Balbi
Hi Wolfram, On Tue, Nov 18, 2014 at 02:19:07PM -0600, Felipe Balbi wrote: On Tue, Nov 18, 2014 at 12:14:21PM -0800, Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 02:03:40PM -0600, Felipe Balbi wrote: On Tue, Nov 18, 2014 at 11:59:02AM -0800, Dmitry Torokhov wrote: On Tue, Nov 18, 2014

[PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-18 Thread Felipe Balbi
Because with OF we can pass more specific compatible flags (such as edt-ft5306) instead of generic edt-ft5x06, when i2c-core's of_i2c_register_devices() tries to request_module(), it'll request it with a non-existent specific module alias. In order to have this driver autoprobing again, we just

Re: [PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 01:27:42PM -0600, Felipe Balbi wrote: Because with OF we can pass more specific compatible flags (such as edt-ft5306) instead of generic edt-ft5x06, when i2c-core's of_i2c_register_devices() tries to request_module(), it'll request it with a non-existent specific

Re: [PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 01:27:42PM -0600, Felipe Balbi wrote: Because with OF we can pass more specific compatible flags (such as edt-ft5306) instead of generic edt-ft5x06, when i2c-core's of_i2c_register_devices() tries to request_module(), it'll request it with a non-existent specific

Re: [PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 11:59:02AM -0800, Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 01:27:42PM -0600, Felipe Balbi wrote: Because with OF we can pass more specific compatible flags (such as edt-ft5306) instead of generic edt-ft5x06, when i2c-core's of_i2c_register_devices() tries to

Re: [PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-18 Thread Dmitry Torokhov
On Tue, Nov 18, 2014 at 02:03:40PM -0600, Felipe Balbi wrote: On Tue, Nov 18, 2014 at 11:59:02AM -0800, Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 01:27:42PM -0600, Felipe Balbi wrote: Because with OF we can pass more specific compatible flags (such as edt-ft5306) instead of

Re: [PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-18 Thread Felipe Balbi
On Tue, Nov 18, 2014 at 12:14:21PM -0800, Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 02:03:40PM -0600, Felipe Balbi wrote: On Tue, Nov 18, 2014 at 11:59:02AM -0800, Dmitry Torokhov wrote: On Tue, Nov 18, 2014 at 01:27:42PM -0600, Felipe Balbi wrote: Because with OF we can pass more