Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-09 Thread Arnd Bergmann
On Wednesday 09 May 2012, Christoph Hellwig wrote: > On Wed, May 09, 2012 at 01:59:40PM +, Arnd Bergmann wrote: > > My feeling is that we should just treat every (REQ_SYNC | REQ_READ) > > request the same and let them interrupt long-running writes, > > independent of whether it's REQ_META or de

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-09 Thread Vivek Goyal
On Mon, May 07, 2012 at 10:16:30PM +0530, S, Venkatraman wrote: [..] > This feature doesn't fiddle with the I/O scheduler's ability to balance > read vs write requests or handling requests from various process queues (CFQ). > Does this feature work with CFQ? As CFQ does not submit sync IO (for i

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-09 Thread Christoph Hellwig
On Wed, May 09, 2012 at 01:59:40PM +, Arnd Bergmann wrote: > My feeling is that we should just treat every (REQ_SYNC | REQ_READ) > request the same and let them interrupt long-running writes, > independent of whether it's REQ_META or demand paging. It's funny that the CFQ scheduler used to boo

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-09 Thread Arnd Bergmann
On Wednesday 09 May 2012, Dave Chinner wrote: > > In low end flash devices, some requests might take too long than normal > > due to background device maintenance (i.e flash erase / reclaim procedure) > > kicking in in the context of an ongoing write, stalling them by several > > orders of magnitud

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-08 Thread Dave Chinner
On Mon, May 07, 2012 at 10:16:30PM +0530, S, Venkatraman wrote: > Mon, May 7, 2012 at 5:01 AM, Dave Chinner wrote: > > On Thu, May 03, 2012 at 07:53:00PM +0530, Venkatraman S wrote: > >> From: Ilan Smith > >> > >> Add attribute to identify demand paging requests. > >> Mark readpages with demand p

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-08 Thread S, Venkatraman
On Tue, May 8, 2012 at 11:58 AM, mani wrote: > How about adding the AS_DMPG flag in the file -> address_space when getting > a filemap_fault() > so that we can treat the page fault pages as the high priority pages over > normal read requests. > How about changing below lines for the support of the

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-07 Thread S, Venkatraman
Mon, May 7, 2012 at 5:01 AM, Dave Chinner wrote: > On Thu, May 03, 2012 at 07:53:00PM +0530, Venkatraman S wrote: >> From: Ilan Smith >> >> Add attribute to identify demand paging requests. >> Mark readpages with demand paging attribute. >> >> Signed-off-by: Ilan Smith >> Signed-off-by: Alex Lem

Re: [PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-06 Thread Dave Chinner
On Thu, May 03, 2012 at 07:53:00PM +0530, Venkatraman S wrote: > From: Ilan Smith > > Add attribute to identify demand paging requests. > Mark readpages with demand paging attribute. > > Signed-off-by: Ilan Smith > Signed-off-by: Alex Lemberg > Signed-off-by: Venkatraman S > --- > fs/mpage.c

[PATCH v2 01/16] FS: Added demand paging markers to filesystem

2012-05-03 Thread Venkatraman S
From: Ilan Smith Add attribute to identify demand paging requests. Mark readpages with demand paging attribute. Signed-off-by: Ilan Smith Signed-off-by: Alex Lemberg Signed-off-by: Venkatraman S --- fs/mpage.c|2 ++ include/linux/bio.h |7 +++ include/linux/