Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-06 Thread Linus Walleij
2010/8/4 Ohad Ben-Cohen o...@wizery.com: On Wed, Aug 4, 2010 at 2:41 PM, Russell King - ARM Linux Why not arrange for a small piece of code to be built into the kernel when this driver is selected as a module or built-in, which handles the passing of platform data to the driver? It's

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-06 Thread Ohad Ben-Cohen
On Fri, Aug 6, 2010 at 10:07 AM, Linus Walleij linus.ml.wall...@gmail.com wrote: 2010/8/4 Ohad Ben-Cohen o...@wizery.com: On Wed, Aug 4, 2010 at 2:41 PM, Russell King - ARM Linux Why not arrange for a small piece of code to be built into the kernel when this driver is selected as a module or

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-06 Thread Russell King - ARM Linux
On Fri, Aug 06, 2010 at 01:02:24PM +0300, Ohad Ben-Cohen wrote: We have Russell's suggestion which is nice and simple, but it has the 1 device limitation. You could make it generic by doing something like this: #define set_device_data(name, type, index, data)\ ({

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-06 Thread Nicolas Pitre
On Fri, 6 Aug 2010, Russell King - ARM Linux wrote: On Fri, Aug 06, 2010 at 01:02:24PM +0300, Ohad Ben-Cohen wrote: We have Russell's suggestion which is nice and simple, but it has the 1 device limitation. You could make it generic by doing something like this: #define

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-04 Thread Ohad Ben-Cohen
Hi Vitaly, On Tue, Aug 3, 2010 at 5:17 PM, Vitaly Wool vitalyw...@gmail.com wrote: On Mon, Aug 2, 2010 at 11:35 PM, Ohad Ben-Cohen o...@wizery.com wrote: I'm honestly trying to understand your concerns, but I'm afraid that just saying it's a hack is not too informative. Can you please explain

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-04 Thread Russell King - ARM Linux
On Wed, Aug 04, 2010 at 02:24:39PM +0300, Ohad Ben-Cohen wrote: Hi Vitaly, On Tue, Aug 3, 2010 at 5:17 PM, Vitaly Wool vitalyw...@gmail.com wrote: On Mon, Aug 2, 2010 at 11:35 PM, Ohad Ben-Cohen o...@wizery.com wrote: I'm honestly trying to understand your concerns, but I'm afraid that

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-04 Thread Ohad Ben-Cohen
On Wed, Aug 4, 2010 at 2:41 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Aug 04, 2010 at 02:24:39PM +0300, Ohad Ben-Cohen wrote: On Tue, Aug 3, 2010 at 5:17 PM, Vitaly Wool vitalyw...@gmail.com wrote: On Mon, Aug 2, 2010 at 11:35 PM, Ohad Ben-Cohen o...@wizery.com wrote:

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-04 Thread Vitaly Wool
On Wed, Aug 4, 2010 at 2:42 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Wed, Aug 4, 2010 at 2:41 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Aug 04, 2010 at 02:24:39PM +0300, Ohad Ben-Cohen wrote: On Tue, Aug 3, 2010 at 5:17 PM, Vitaly Wool vitalyw...@gmail.com wrote:

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-03 Thread Vitaly Wool
Hi Ohad, On Mon, Aug 2, 2010 at 11:35 PM, Ohad Ben-Cohen o...@wizery.com wrote: I'm honestly trying to understand your concerns, but I'm afraid that just saying it's a hack is not too informative. Can you please explain what do you think is technically wrong with the proposed solution ? is

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-02 Thread Ohad Ben-Cohen
Hi Vitaly, On Thu, Jul 29, 2010 at 7:16 PM, Vitaly Wool vitalyw...@gmail.com wrote: On Thu, Jul 29, 2010 at 8:00 AM, Ohad Ben-Cohen o...@wizery.com wrote: To my understanding, this data doesn't belong to mmc_host. It's not a host data at all. E. g. imagine a GPIO IRQ for some SDIO chip -- it's

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-02 Thread Vitaly Wool
Hi Ohad, On Mon, Aug 2, 2010 at 5:54 PM, Ohad Ben-Cohen o...@wizery.com wrote: SPI is using these spi_board_info tables to populate the SPI device trees. These tables are registered early at the board-specific init code, and are later used by SPI core to populate the devices when the SPI

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-02 Thread Ohad Ben-Cohen
Hi Vitaly, On Mon, Aug 2, 2010 at 7:25 PM, Vitaly Wool vitalyw...@gmail.com wrote: On Mon, Aug 2, 2010 at 5:54 PM, Ohad Ben-Cohen o...@wizery.com wrote: SPI is using these spi_board_info tables to populate the SPI device trees. These tables are registered early at the board-specific init

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-07-29 Thread Ohad Ben-Cohen
Hi Vitaly, On Wed, Jul 28, 2010 at 10:47 PM, Vitaly Wool vitalyw...@gmail.com wrote: On Wed, Jul 21, 2010 at 7:33 PM, Ohad Ben-Cohen o...@wizery.com wrote: Add support to set/get mmc_host private embedded data. This is needed to allow software to dynamically create (and remove) SDIO

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-07-29 Thread Vitaly Wool
Hi Ohad, On Thu, Jul 29, 2010 at 8:00 AM, Ohad Ben-Cohen o...@wizery.com wrote: To my understanding, this data doesn't belong to mmc_host. It's not a host data at all. E. g. imagine a GPIO IRQ for some SDIO chip -- it's totally unrelated to host. I think a cleaner way would be to introduce

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-07-28 Thread Vitaly Wool
Hi Ohad, On Wed, Jul 21, 2010 at 7:33 PM, Ohad Ben-Cohen o...@wizery.com wrote: Add support to set/get mmc_host private embedded data. This is needed to allow software to dynamically create (and remove) SDIO functions which represents embedded SDIO devices. snip @@ -209,6 +209,8 @@ struct

[PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-07-21 Thread Ohad Ben-Cohen
Add support to set/get mmc_host private embedded data. This is needed to allow software to dynamically create (and remove) SDIO functions which represents embedded SDIO devices. Typically, it will be used to set the context of a driver that is creating a new SDIO function (and would then expect