Re: [PATCH v2 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards

2013-02-18 Thread Ruslan Bilovol
Hi Andy, On Sun, Feb 17, 2013 at 4:17 PM, Andi Shyti andi.sh...@gmail.com wrote: + char name[30]; + char buf[50]; + + if (size = sizeof(buf)) + size = sizeof(buf); what's the point of this? This is a way to limit copied from userspace data by available

Re: [PATCH v2 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards

2013-02-17 Thread Andi Shyti
+ char name[30]; + char buf[50]; + + if (size = sizeof(buf)) + size = sizeof(buf); what's the point of this? This is a way to limit copied from userspace data by available buffer size, widely used in current kernel sources. Are you implying there is some

Re: [PATCH v2 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards

2013-02-13 Thread Ruslan Bilovol
Hi Andi, Thanks for your review, On Mon, Feb 11, 2013 at 1:51 AM, Andi Shyti a...@etezian.org wrote: Hi Ruslan, TC358765 is DSI-to-LVDS transmitter from Toshiba, used in OMAP44XX Blaze Tablet and Blaze Tablet2 boards. I think it's fine, just some nitpicks and checkpatch warnings +struct

Re: [PATCH v2 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards

2013-02-10 Thread Andi Shyti
Hi Ruslan, TC358765 is DSI-to-LVDS transmitter from Toshiba, used in OMAP44XX Blaze Tablet and Blaze Tablet2 boards. I think it's fine, just some nitpicks and checkpatch warnings +struct { + struct device *dev; + struct dentry *dir; +} tc358765_debug; Should this be static?

[PATCH v2 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards

2013-02-08 Thread Ruslan Bilovol
From: Tomi Valkeinen tomi.valkei...@ti.com TC358765 is DSI-to-LVDS transmitter from Toshiba, used in OMAP44XX Blaze Tablet and Blaze Tablet2 boards. Signed-off-by: Dan Murphy dmur...@ti.com Signed-off-by: Sergiy Kibrik sergiy.kib...@globallogic.com Signed-off-by: Volodymyr Riazantsev