On 09/09/2014 04:39 PM, Roger Quadros wrote:
On 09/09/2014 05:34 PM, Marc Kleine-Budde wrote:
On 09/09/2014 04:31 PM, Roger Quadros wrote:
Pass the correct 'mask' and 'value' bits to c_can_hw_raminit_wait_ti().
They seem to have been swapped in the usage instances.
Can you split this fix
Pass the correct 'mask' and 'value' bits to c_can_hw_raminit_wait_ti().
They seem to have been swapped in the usage instances.
TI's RAMINIT DONE mechanism is buggy and may not always be
set after the START bit is set. So add a timeout mechanism to
c_can_hw_raminit_wait_ti().
Signed-off-by: Roger
On 09/09/2014 09:31 AM, Roger Quadros wrote:
Pass the correct 'mask' and 'value' bits to c_can_hw_raminit_wait_ti().
They seem to have been swapped in the usage instances.
TI's RAMINIT DONE mechanism is buggy and may not always be
set after the START bit is set. So add a timeout mechanism to
On 09/09/2014 04:31 PM, Roger Quadros wrote:
Pass the correct 'mask' and 'value' bits to c_can_hw_raminit_wait_ti().
They seem to have been swapped in the usage instances.
Can you split this fix into a seperate patch, please.
TI's RAMINIT DONE mechanism is buggy and may not always be
set
On 09/09/2014 05:34 PM, Marc Kleine-Budde wrote:
On 09/09/2014 04:31 PM, Roger Quadros wrote:
Pass the correct 'mask' and 'value' bits to c_can_hw_raminit_wait_ti().
They seem to have been swapped in the usage instances.
Can you split this fix into a seperate patch, please.
OK.
TI's
On 09/09/2014 05:34 PM, Nishanth Menon wrote:
On 09/09/2014 09:31 AM, Roger Quadros wrote:
Pass the correct 'mask' and 'value' bits to c_can_hw_raminit_wait_ti().
They seem to have been swapped in the usage instances.
TI's RAMINIT DONE mechanism is buggy and may not always be
set after the
On 09/09/2014 09:45 AM, Roger Quadros wrote:
[...]
/* We look only at the bits of our instance. */
val = mask;
- while ((readl(priv-raminit_ctrlreg) mask) != val)
+ while ((readl(priv-raminit_ctrlreg) mask) != val) {
udelay(1);
+ timeout++;
+
+
On 09/09/2014 05:51 PM, Nishanth Menon wrote:
On 09/09/2014 09:45 AM, Roger Quadros wrote:
[...]
/* We look only at the bits of our instance. */
val = mask;
- while ((readl(priv-raminit_ctrlreg) mask) != val)
+ while ((readl(priv-raminit_ctrlreg) mask) != val) {
