Re: [PATCH v2 2/2] OMAP: omap_device: API to modify AUTOIDLE and SMARTIDLE bits

2011-03-01 Thread Cousson, Benoit
On 3/1/2011 12:27 PM, ABRAHAM, KISHON VIJAY wrote: On Tue, Mar 1, 2011 at 4:47 PM, Cousson, Benoit wrote: Hi Kishon, Sorry for this late reply. I'm fine with this omap_device API which is well aligned with the discussion we had. I just have few minor comments about the split omap_hwmod / omap

Re: [PATCH v2 2/2] OMAP: omap_device: API to modify AUTOIDLE and SMARTIDLE bits

2011-03-01 Thread ABRAHAM, KISHON VIJAY
On Tue, Mar 1, 2011 at 4:47 PM, Cousson, Benoit wrote: > Hi Kishon, > > Sorry for this late reply. > > I'm fine with this omap_device API which is well aligned with the discussion > we had. I just have few minor comments about the split omap_hwmod / > omap_device. > > To summarize, you should not

Re: [PATCH v2 2/2] OMAP: omap_device: API to modify AUTOIDLE and SMARTIDLE bits

2011-03-01 Thread Cousson, Benoit
Hi Kishon, Sorry for this late reply. I'm fine with this omap_device API which is well aligned with the discussion we had. I just have few minor comments about the split omap_hwmod / omap_device. To summarize, you should not hack directly hwmod internal attributes from the upper layer. Yo

[PATCH v2 2/2] OMAP: omap_device: API to modify AUTOIDLE and SMARTIDLE bits

2011-01-31 Thread Kishon Vijay Abraham I
Provide APIs to be used by the driver in order to modify AUTOIDLE and SIDLE bits. These APIs in turn call hwmod APIs to modify the SYSCONFIG register. Signed-off-by: Kishon Vijay Abraham I Signed-off-by: Benoit Cousson Cc: Paul Walmsley --- arch/arm/plat-omap/include/plat/omap_device.h |6