Re: [PATCH v2 2/4] arm: omap4: usb: add platform init code for EHCI

2010-12-06 Thread Tony Lindgren
* Anand Gadiyar gadi...@ti.com [101130 13:56]: On 12/1/2010 3:10 AM, Tony Lindgren wrote: * Anand Gadiyar gadi...@ti.com [101129 09:16]: - Add platform init code for EHCI on OMAP4 - Add pad configuration for PHY and TLL modes Signed-off-by: Anand Gadiyar gadi...@ti.com Looks OK to

Re: [PATCH v2 2/4] arm: omap4: usb: add platform init code for EHCI

2010-11-30 Thread Tony Lindgren
* Anand Gadiyar gadi...@ti.com [101129 09:16]: - Add platform init code for EHCI on OMAP4 - Add pad configuration for PHY and TLL modes Signed-off-by: Anand Gadiyar gadi...@ti.com Looks OK to me. You might want to check if all these signals are unique though and do not have alternate paths.

Re: [PATCH v2 2/4] arm: omap4: usb: add platform init code for EHCI

2010-11-30 Thread Anand Gadiyar
On 12/1/2010 3:10 AM, Tony Lindgren wrote: * Anand Gadiyar gadi...@ti.com [101129 09:16]: - Add platform init code for EHCI on OMAP4 - Add pad configuration for PHY and TLL modes Signed-off-by: Anand Gadiyar gadi...@ti.com Looks OK to me. You might want to check if all these signals are

[PATCH v2 2/4] arm: omap4: usb: add platform init code for EHCI

2010-11-29 Thread Anand Gadiyar
- Add platform init code for EHCI on OMAP4 - Add pad configuration for PHY and TLL modes Signed-off-by: Anand Gadiyar gadi...@ti.com Cc: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/usb-ehci.c | 144 +-- 1 files changed, 136 insertions(+), 8